tests_lit/llvm2ice_tests/phi_invalid.test - Issue 1387963002: Make sure that all globals are internal, except for "start" functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests_lit/llvm2ice_tests/phi_invalid.test

Issue 1387963002: Make sure that all globals are internal, except for "start" functions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nit. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tests_lit/llvm2ice_tests/nacl-mem-intrinsics.ll ('K') | « tests_lit/llvm2ice_tests/nop-insertion.ll ('k') | tests_lit/llvm2ice_tests/prune_unreachable.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests_lit/llvm2ice_tests/phi_invalid.test

diff --git a/tests_lit/llvm2ice_tests/phi_invalid.test b/tests_lit/llvm2ice_tests/phi_invalid.test

index 184f08c378e3cbca69c356b666d1e27f5242acbe..d8323dbf5cff5fd612d4a0b15654692d6f433ade 100644

--- a/tests_lit/llvm2ice_tests/phi_invalid.test

+++ b/tests_lit/llvm2ice_tests/phi_invalid.test

@@ -3,6 +3,7 @@

RUN: %p2i --expect-fail --tbc -i %p/Input/phi-invalid.tbc --insts 2>&1 \

RUN: --filetype=obj --args -o /dev/null \

+RUN: -allow-externally-defined-symbols \

RUN: | FileCheck --check-prefix=BADPHI %s

; BADPHI: Phi error:

« tests_lit/llvm2ice_tests/nacl-mem-intrinsics.ll ('K') | « tests_lit/llvm2ice_tests/nop-insertion.ll ('k') | tests_lit/llvm2ice_tests/prune_unreachable.ll » ('j') | no next file with comments »