Make sure that all globals are internal, except for "start" functions.

src/IceClFlags.h

Index: src/IceClFlags.h
diff --git a/src/IceClFlags.h b/src/IceClFlags.h
index 87e16cd5201b9923a4066e921bd108ec454b08e8..afefd07b1f056939975ef5f1bd3c91d1b1be5abc 100644
--- a/src/IceClFlags.h
+++ b/src/IceClFlags.h
@@ -39,6 +39,13 @@ public:
   bool getAllowErrorRecovery() const { return AllowErrorRecovery; }
   void setAllowErrorRecovery(bool NewValue) { AllowErrorRecovery = NewValue; }
 
+  bool getAllowExternDefinedSymbols() const {
+    return AllowExternDefinedSymbols;
+  }
+  void setAllowExternDefinedSymbols(bool NewValue) {
+    AllowExternDefinedSymbols = NewValue;
+  }
+
   bool getAllowIacaMarks() const { return AllowIacaMarks; }
   void setAllowIacaMarks(bool NewValue) { AllowIacaMarks = NewValue; }
 
@@ -238,6 +245,7 @@ public:
 
 private:
   bool AllowErrorRecovery;
+  bool AllowExternDefinedSymbols = false;

[John, 2015/10/06 19:30:15]

I have mixed feelings about this initialization here. while we do want to use it
whenever possible, nothing else uses it in this class. What about initializing
the member in the ctor, and leave a TODO() here for someone to fix all inits?

[Jim Stichnoth, 2015/10/06 20:16:21]

I agree that there should be consistency here.

[Karl, 2015/10/06 21:47:18]

Done.

   bool AllowIacaMarks;
   bool AllowUninitializedGlobals;
   bool DataSections;