Make sure that all globals are internal, except for "start" functions.

src/IceClFlags.h

 //===- subzero/src/IceClFlags.h - Cl Flags for translation ------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 21 matching lines @@
   static void parseFlags(int argc, char *argv[]);
   static void resetClFlags(ClFlags &OutFlags);
   static void getParsedClFlags(ClFlags &OutFlags);
   static void getParsedClFlagsExtra(ClFlagsExtra &OutFlagsExtra);
 
   // bool accessors.
 
   bool getAllowErrorRecovery() const { return AllowErrorRecovery; }
   void setAllowErrorRecovery(bool NewValue) { AllowErrorRecovery = NewValue; }
 
+  bool getAllowExternDefinedSymbols() const {
+    return AllowExternDefinedSymbols;
+  }
+  void setAllowExternDefinedSymbols(bool NewValue) {
+    AllowExternDefinedSymbols = NewValue;
+  }
+
   bool getAllowIacaMarks() const { return AllowIacaMarks; }
   void setAllowIacaMarks(bool NewValue) { AllowIacaMarks = NewValue; }
 
   bool getAllowUninitializedGlobals() const {
     return AllowUninitializedGlobals;
   }
   void setAllowUninitializedGlobals(bool NewValue) {
     AllowUninitializedGlobals = NewValue;
   }
 
@@ skipping 179 matching lines @@
   bool isSequential() const { return NumTranslationThreads == 0; }
   void setNumTranslationThreads(size_t NewValue) {
     NumTranslationThreads = NewValue;
   }
 
   uint64_t getRandomSeed() const { return RandomSeed; }
   void setRandomSeed(size_t NewValue) { RandomSeed = NewValue; }
 
 private:
   bool AllowErrorRecovery;
+  bool AllowExternDefinedSymbols = false;

[John, 2015/10/06 19:30:15]

I have mixed feelings about this initialization here. while we do want to use it
whenever possible, nothing else uses it in this class. What about initializing
the member in the ctor, and leave a TODO() here for someone to fix all inits?

[Jim Stichnoth, 2015/10/06 20:16:21]

I agree that there should be consistency here.

[Karl, 2015/10/06 21:47:18]

Done.

   bool AllowIacaMarks;
   bool AllowUninitializedGlobals;
   bool DataSections;
   bool DecorateAsm;
   bool DisableInternal;
   bool DisableIRGeneration;
   bool DisableTranslation;
   bool DumpStats;
   bool EnableBlockProfile;
   bool ForceMemIntrinOpt;
@@ skipping 31 matching lines @@
   IceString TranslateOnly;
   IceString VerboseFocusOn;
 
   size_t NumTranslationThreads; // 0 means completely sequential
   uint64_t RandomSeed;
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICECLFLAGS_H