Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Issue 13878009: Control the order of gclient spec keys in fetch (Closed)

Created:
7 years, 8 months ago by janx
Modified:
7 years, 8 months ago
Reviewers:
Dirk Pranke, agable
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, agable
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Control the order of gclient spec keys in fetch Follow the explicit iteration order of the spec keys array instead of relying on the arbitrary iteration order of the hashtable. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=194973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M fetch.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
janx
I was trying to write a recipe for "fetch android" when I noticed that the ...
7 years, 8 months ago (2013-04-18 13:58:56 UTC) #1
Dirk Pranke
lgtm
7 years, 8 months ago (2013-04-18 16:42:07 UTC) #2
agable
Nice catch, LGTM.
7 years, 8 months ago (2013-04-18 16:43:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/janx@chromium.org/13878009/1
7 years, 8 months ago (2013-04-18 18:31:13 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 18:33:52 UTC) #5
Message was sent while issue was closed.
Change committed as 194973

Powered by Google App Engine
This is Rietveld 408576698