Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: fetch.py

Issue 13878009: Control the order of gclient spec keys in fetch (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fetch.py
diff --git a/fetch.py b/fetch.py
index aca0f88d60945c16fb49d9d79051e3553a2e6009..c78dfe722b9ca060075b647d8c1624c364375c66 100755
--- a/fetch.py
+++ b/fetch.py
@@ -102,7 +102,7 @@ class GclientGitCheckout(GclientCheckout, GitCheckout):
assert 'solutions' in self.spec
keys = ['solutions', 'target_os', 'target_os_only']
gclient_spec = '\n'.join('%s = %s' % (key, self.spec[key])
- for key in self.spec if key in keys)
+ for key in keys if key in self.spec)
self.spec['gclient_spec'] = gclient_spec
def exists(self):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698