Move GpuMemoryBuffer interface from ui/gl to gpu/command_buffer/client

Move GpuMemoryBuffer interface from ui/gl to gpu/command_buffer/client

BUG=175012
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195112

[joth, 2013-04-17 22:25:22]

lgtm

[apatrick_chromium, 2013-04-17 22:27:20]

https://codereview.chromium.org/13870010/diff/3027/android_webview/browser/DEPS
File android_webview/browser/DEPS (right):

https://codereview.chromium.org/13870010/diff/3027/android_webview/browser/DE...
android_webview/browser/DEPS:15:
"+gpu/command_buffer/client/gpu_memory_buffer.h",
You could just do "+gpu/command_buffer/client/" here I think.

[kaanb, 2013-04-17 23:05:32]

https://codereview.chromium.org/13870010/diff/3027/android_webview/browser/DEPS
File android_webview/browser/DEPS (right):

https://codereview.chromium.org/13870010/diff/3027/android_webview/browser/DE...
android_webview/browser/DEPS:15:
"+gpu/command_buffer/client/gpu_memory_buffer.h",
On 2013/04/17 22:27:20, apatrick_chromium wrote:
> You could just do "+gpu/command_buffer/client/" here I think.

Done.

[kaanb, 2013-04-18 19:10:20]

On 2013/04/17 23:05:32, kaanb wrote:
>
https://codereview.chromium.org/13870010/diff/3027/android_webview/browser/DEPS
> File android_webview/browser/DEPS (right):
> 
>
https://codereview.chromium.org/13870010/diff/3027/android_webview/browser/DE...
> android_webview/browser/DEPS:15:
> "+gpu/command_buffer/client/gpu_memory_buffer.h",
> On 2013/04/17 22:27:20, apatrick_chromium wrote:
> > You could just do "+gpu/command_buffer/client/" here I think.
> 
> Done.

I've also modified the factory method signature to take in two uint32's instead
of a gfx::Size as we cannot use gfx::Size from gpu/ Please take another look.

[greggman, 2013-04-18 20:37:32]

lgtm

[joth, 2013-04-18 21:18:34]

(more a question for greggman here)

https://codereview.chromium.org/13870010/diff/16001/gpu/command_buffer/client...
File gpu/command_buffer/client/gpu_memory_buffer.h (right):

https://codereview.chromium.org/13870010/diff/16001/gpu/command_buffer/client...
gpu/command_buffer/client/gpu_memory_buffer.h:25: typedef
base::Callback<scoped_ptr<GpuMemoryBuffer>(uint32, uint32)> Creator;
Size is 'int' and gpu/ tends to use GLsizei (also signed) so should we just be
using 'int' here?

[greggman, 2013-04-18 21:32:08]

lgtm

[commit-bot: I haz the power, 2013-04-18 21:40:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaanb@chromium.org/13870010/17014

[commit-bot: I haz the power, 2013-04-18 21:40:21]

Presubmit check for 13870010-17014 failed and returned exit status 1.

INFO:root:Found 12 file(s).
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1305, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1129, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1046, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 865, in CheckChangeOnCommit
  File "<string>", line 700, in _CommonChecks
  File "<string>", line 258, in _CheckNoUNIT_TESTInSourceFiles
  File "/b/depot_tools/presubmit_support.py", line 549, in ChangedContents
    for line in self.GenerateScmDiff().splitlines():
  File "/b/depot_tools/presubmit_support.py", line 619, in GenerateScmDiff
    [self.LocalPath()], self._local_root, False, None)
  File "/b/depot_tools/scm.py", line 913, in GenerateDiff
    full_move, revision))
  File "/b/depot_tools/scm.py", line 837, in _DiffItemInternal
    data = SVN.Capture(command, cwd)
  File "/b/depot_tools/scm.py", line 479, in Capture
    ['svn'] + args, stderr=subprocess2.PIPE, cwd=cwd, **kwargs)
  File "/b/depot_tools/subprocess2.py", line 449, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File "/b/depot_tools/subprocess2.py", line 412, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
subprocess2.CalledProcessError: Command svn diff --internal-diff
android_webview/browser/gpu_memory_buffer_factory_impl.cc returned non-zero exit
status 1 in /b/commit-queue/workdir/chromium
svn: invalid option: --internal-diff
Type 'svn help' for usage.

[commit-bot: I haz the power, 2013-04-18 21:47:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaanb@chromium.org/13870010/17015

[commit-bot: I haz the power, 2013-04-18 22:13:56]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-18 22:25:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaanb@chromium.org/13870010/21003

[commit-bot: I haz the power, 2013-04-18 23:05:01]

Retried try job too often on ios_rel_device for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-04-18 23:06:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaanb@chromium.org/13870010/21003

[commit-bot: I haz the power, 2013-04-18 23:45:02]

Retried try job too often on ios_rel_device for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-04-19 00:16:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaanb@chromium.org/13870010/21003

[commit-bot: I haz the power, 2013-04-19 08:59:00]

Change committed as 195112