Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13861033: Remove Apple's unused implementation of private browsing from WebCore (Closed)

Created:
7 years, 8 months ago by pilgrim_google
Modified:
7 years, 8 months ago
Reviewers:
levin, abarth-chromium
CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, feature-media-reviews_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, Stephen Chennney, Nate Chapin, vcarbune.chromium, jochen+watch_chromium.org, abarth-chromium, darin (slow to review)
Visibility:
Public.

Description

Superseded by https://codereview.chromium.org/14142009 because git is confusing.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Repatching to ToT #

Patch Set 3 : Repatch fix #

Patch Set 4 : Repatch to ToT #

Patch Set 5 : Repatch to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -953 lines) Patch
D LayoutTests/http/tests/security/cross-frame-access-private-browsing.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/http/tests/security/cross-frame-access-private-browsing-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-plugin-private-browsing-toggled.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html View 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-loosened-private-browsing-plugin.html View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-loosened-private-browsing-plugin-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/http/tests/security/storage-blocking-strengthened-private-browsing-plugin-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/inspector/console/clients-ignored-in-privatebrowsing.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/inspector/console/clients-ignored-in-privatebrowsing-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/platform/chromium/http/tests/security/cross-frame-access-private-browsing-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/plugins/private-browsing-mode.html View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/plugins/private-browsing-mode-2.html View 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/plugins/private-browsing-mode-2-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/plugins/private-browsing-mode-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/storage/domstorage/localstorage/private-browsing-affects-storage.html View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/storage/domstorage/localstorage/private-browsing-affects-storage-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/storage/domstorage/sessionstorage/private-browsing-affects-storage.html View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/storage/domstorage/sessionstorage/private-browsing-affects-storage-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/storage/websql/private-browsing-noread-nowrite.html View 1 chunk +0 lines, -102 lines 0 comments Download
D LayoutTests/storage/websql/private-browsing-noread-nowrite-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/WebCore/dom/Document.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/dom/Document.cpp View 1 2 chunks +0 lines, -18 lines 0 comments Download
M Source/WebCore/dom/Element.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/html/HTMLMediaElement.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/html/HTMLMediaElement.cpp View 1 4 chunks +0 lines, -17 lines 0 comments Download
M Source/WebCore/loader/HistoryController.cpp View 1 8 chunks +3 lines, -21 lines 0 comments Download
M Source/WebCore/loader/icon/IconDatabase.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/loader/icon/IconDatabaseBase.h View 1 chunk +0 lines, -1 line 0 comments Download
Source/WebCore/page/Console.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/page/Page.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/page/Page.cpp View 1 1 chunk +0 lines, -16 lines 0 comments Download
M Source/WebCore/page/PageConsole.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/page/Settings.h View 1 2 chunks +0 lines, -17 lines 0 comments Download
M Source/WebCore/page/Settings.cpp View 1 2 chunks +0 lines, -10 lines 0 comments Download
M Source/WebCore/platform/SchemeRegistry.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/WebCore/platform/SchemeRegistry.cpp View 2 chunks +0 lines, -36 lines 0 comments Download
M Source/WebCore/platform/graphics/MediaPlayer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/platform/graphics/MediaPlayer.cpp View 3 chunks +0 lines, -8 lines 0 comments Download
M Source/WebCore/platform/graphics/MediaPlayerPrivate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/plugins/PluginViewBase.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/rendering/RenderSearchField.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/storage/StorageAreaImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/storage/StorageAreaImpl.cpp View 8 chunks +0 lines, -28 lines 0 comments Download
M Source/modules/webdatabase/DatabaseContext.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Tools/DumpRenderTree/DumpRenderTree.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D Tools/DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp View 1 chunk +0 lines, -106 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
pilgrim_google
7 years, 8 months ago (2013-04-10 18:31:55 UTC) #1
abarth-chromium
7 years, 8 months ago (2013-04-10 18:40:03 UTC) #2 
LGTM!!

https://codereview.chromium.org/13861033/diff/1/Source/WebCore/Modules/webdat...
File Source/WebCore/Modules/webdatabase/DatabaseContext.cpp (right):

https://codereview.chromium.org/13861033/diff/1/Source/WebCore/Modules/webdat...
Source/WebCore/Modules/webdatabase/DatabaseContext.cpp:209: return true;
This can be simplified to just "return document->page();"

https://codereview.chromium.org/13861033/diff/1/Source/WebCore/platform/netwo...
File Source/WebCore/platform/network/NetworkStorageSessionStub.cpp (left):

https://codereview.chromium.org/13861033/diff/1/Source/WebCore/platform/netwo...
Source/WebCore/platform/network/NetworkStorageSessionStub.cpp:48:
PassOwnPtr<NetworkStorageSession>
NetworkStorageSession::createPrivateBrowsingSession(const String&)
We can probably delete this whole file.  (Maybe I did that already?)

Powered by Google App Engine
This is Rietveld 408576698