Add thread-per-core setting to SkThreadPool.

Add thread-per-core setting to SkThreadPool.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=8802

[caryclark, 2013-04-19 18:37:12]

https://codereview.chromium.org/13855009/diff/1/src/utils/SkThreadPool.cpp
File src/utils/SkThreadPool.cpp (right):

https://codereview.chromium.org/13855009/diff/1/src/utils/SkThreadPool.cpp#ne...
src/utils/SkThreadPool.cpp:27: return 1;
SK_BUILD_ANDROID ?
could this use the sysconf call?
please add a TODO if not

https://codereview.chromium.org/13855009/diff/1/tests/PathOpsExtendedTest.cpp
File tests/PathOpsExtendedTest.cpp (right):

https://codereview.chromium.org/13855009/diff/1/tests/PathOpsExtendedTest.cpp...
tests/PathOpsExtendedTest.cpp:537: return reporter->allowThreaded() ?
SkThreadPool::kThreadPerCore : 0;
Are 0 and 1 interchangeable? The old code returned 1 if no threads were allowed.

[scroggo, 2013-04-19 18:43:35]

https://codereview.chromium.org/13855009/diff/1/src/utils/SkThreadPool.cpp
File src/utils/SkThreadPool.cpp (right):

https://codereview.chromium.org/13855009/diff/1/src/utils/SkThreadPool.cpp#ne...
src/utils/SkThreadPool.cpp:19: int numCores() {
Should this be num_cores(), as if this were a static function?

[mtklein, 2013-04-19 18:52:59]

https://codereview.chromium.org/13855009/diff/1/src/utils/SkThreadPool.cpp
File src/utils/SkThreadPool.cpp (right):

https://codereview.chromium.org/13855009/diff/1/src/utils/SkThreadPool.cpp#ne...
src/utils/SkThreadPool.cpp:19: int numCores() {
On 2013/04/19 18:43:35, scroggo wrote:
> Should this be num_cores(), as if this were a static function?

Yes, done.

https://codereview.chromium.org/13855009/diff/1/src/utils/SkThreadPool.cpp#ne...
src/utils/SkThreadPool.cpp:27: return 1;
On 2013/04/19 18:37:12, caryclark wrote:
> SK_BUILD_ANDROID ?
> could this use the sysconf call?
> please add a TODO if not
Yes, that'll work there too.  Done.

https://codereview.chromium.org/13855009/diff/1/tests/PathOpsExtendedTest.cpp
File tests/PathOpsExtendedTest.cpp (right):

https://codereview.chromium.org/13855009/diff/1/tests/PathOpsExtendedTest.cpp...
tests/PathOpsExtendedTest.cpp:537: return reporter->allowThreaded() ?
SkThreadPool::kThreadPerCore : 0;
On 2013/04/19 18:37:12, caryclark wrote:
> Are 0 and 1 interchangeable? The old code returned 1 if no threads were
allowed.

Very similar.  1 will spawn a new thread and run all calls there.  0 makes the
calls immediately on the current thread.  Seemed to me like 0 was the spirit of
!allowThreaded().

[scroggo, 2013-04-19 18:54:53]

lgtm

[caryclark, 2013-04-19 18:55:17]

lgtm

[caryclark, 2013-04-19 18:55:21]

lgtm

[commit-bot: I haz the power, 2013-04-19 19:16:07]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@google.com/13855009/4002

[commit-bot: I haz the power, 2013-04-22 15:23:16]

Change committed as 8802