Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 13852023: Reland "gpu: Fix Vivante's "hisilicon" GPUs" (Closed)

Created:
7 years, 8 months ago by epenner
Modified:
7 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@HUAWEI_revert
Visibility:
Public.

Description

Reland "gpu: Fix Vivante's "hisilicon" GPUs" This fixes "Hisilicon" GPUs, which is an instance of a Vivante's GPU design. This involves enabling virtual contexts, since they don't support share-groups, and further adds a work-around for switching surfaces. Without the work- around the view surface "inherits" the size of the last bound surface (which for Chrome tends to be a 1x1 pbuffer) resulting in a black screen. The following steps "repair" the view surface every time it is made current: - Make it current. - Bind the default frame-buffer. - Make it not current. - Destroy/recreate it from the native handle. - Make it current again. NOTE: The "Recreate" function is added to surface because the Destroy/Initialize may be intercepted or modified by wrapper surface classes. Recreate is similar to resize, which after being forwarded by a wrapper can call Destroy/Initialize on the 'real' surface. BUG=179250 NOTRY=true No-try, as all the relevant bots are already green. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195349

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -2 lines) Patch
M content/gpu/gpu_info_collector_android.cc View 2 chunks +3 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 3 chunks +5 lines, -0 lines 1 comment Download
M gpu/command_buffer/service/gl_context_virtual.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_context.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_context.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_context_egl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gl/gl_context_egl.cc View 3 chunks +47 lines, -1 line 0 comments Download
M ui/gl/gl_surface.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gl/gl_surface.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
epenner
Ptal. New Patch
7 years, 8 months ago (2013-04-19 03:54:24 UTC) #1
epenner
On 2013/04/19 03:54:24, epenner wrote: > Ptal. New Patch apatrick@: I refactored it partially the ...
7 years, 8 months ago (2013-04-19 04:08:39 UTC) #2
epenner
https://codereview.chromium.org/13852023/diff/1/gpu/command_buffer/service/feature_info.cc File gpu/command_buffer/service/feature_info.cc (right): https://codereview.chromium.org/13852023/diff/1/gpu/command_buffer/service/feature_info.cc#newcode194 gpu/command_buffer/service/feature_info.cc:194: bool is_hisilicon = false; The three lines in this ...
7 years, 8 months ago (2013-04-19 04:13:14 UTC) #3
apatrick_chromium
lgtm
7 years, 8 months ago (2013-04-19 18:38:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/13852023/1
7 years, 8 months ago (2013-04-19 21:09:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/13852023/1
7 years, 8 months ago (2013-04-20 00:25:56 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-20 00:54:28 UTC) #7
Message was sent while issue was closed.
Change committed as 195349

Powered by Google App Engine
This is Rietveld 408576698