Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h

Issue 13845022: Mac: Display a native bubble (instead of the JS one) after the web signin flow. (branched from http… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntpBubble
Patch Set: Ditto Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h
index 2086f355a85633fa14c697316dcce9704eb639cc..46762674b7948f67852493e421d52b86bc6bca62 100644
--- a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h
@@ -15,21 +15,27 @@
@class BrowserWindowController;
@class OneClickSigninViewController;
-// Displays the one-click signin confirmation bubble (after syncing
-// has started).
+// Displays the one-click signin confirmation bubble
@interface OneClickSigninBubbleController : BaseBubbleController {
scoped_nsobject<OneClickSigninViewController> viewController_;
+ @private
+ IBOutlet NSTextField* messageTextField_;
}
@property(readonly, nonatomic) OneClickSigninViewController* viewController;
-// Initializes with a browser window controller, under whose wrench
+// Initializes with a browser window |controller|, under whose wrench
// menu this bubble will be displayed, and callbacks which are called
-// if the user clicks the corresponding link.
+// if the user clicks the corresponding link. |errorMessage| is an
+// alternate message that will be displayed in the case of an authentication
+// error, and |syncCallback| is called to start sync. |webContents| is used
+// to open the Learn More and Advanced links
//
// The bubble is not automatically displayed; call showWindow:id to
// display. The bubble is auto-released on close.
- (id)initWithBrowserWindowController:(BrowserWindowController*)controller
+ webContents:(content::WebContents*)webContents
+ errorMessage:(NSString*)errorMessage
callback:(const BrowserWindow::StartSyncCallback&)
syncCallback;
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698