Issue 13838003: Histogram failure reasons for 3 more LevelDB env methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13838003: Histogram failure reasons for 3 more LevelDB env methods. (Closed)

Created:
7 years, 8 months ago by dgrogan

Modified:
7 years, 8 months ago

Reviewers:
jsbell

CC:
chromium-reviews, alecflett

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Histogram failure reasons for 3 more LevelDB env methods. This will give us reasons for 6 of the top 7 most common failing methods. RenameFile doesn't have a histogram because base::ReplaceFile only returns a bool. Plumbing an error value is planned. BUG=225051 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193012

Patch Set 1 #

Patch Set 2 : move line around #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	third_party/leveldatabase/env_chromium.cc	View	1	4 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/13838003/3

7 years, 8 months ago (2013-04-09 01:03:41 UTC) #3

Message was sent while issue was closed.

Change committed as 193012

Expand Messages | Collapse Messages