Histogram failure reasons for 3 more LevelDB env methods.

third_party/leveldatabase/env_chromium.cc

 // Copyright (c) 2011 The LevelDB Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file. See the AUTHORS file for names of contributors.
 
 #include <errno.h>
 #include <stdio.h>
 
 #include <deque>
 
 #include "base/at_exit.h"
@@ skipping 322 matching lines @@
       result = Status::IOError(filename_, strerror(errno));
       uma_logger_->RecordErrorAt(kWritableFileClose);
     }
     file_ = NULL;
     return result;
   }
 
   virtual Status Flush() {
     Status result;
     if (HANDLE_EINTR(fflush_unlocked(file_))) {
-      result = Status::IOError(filename_, strerror(errno));
-      uma_logger_->RecordErrorAt(kWritableFileFlush);
+      int saved_errno = errno;
+      result = Status::IOError(filename_, strerror(saved_errno));
+      uma_logger_->RecordSpecificError(kWritableFileFlush, saved_errno);
     }
     return result;
   }
 
   virtual Status Sync() {
     Status result;
     int error = 0;
 
     if (HANDLE_EINTR(fflush_unlocked(file_)))
       error = errno;
@@ skipping 20 matching lines @@
   ChromiumEnv();
   virtual ~ChromiumEnv() {
     NOTREACHED();
   }
 
   virtual Status NewSequentialFile(const std::string& fname,
                                    SequentialFile** result) {
     FILE* f = fopen_internal(fname.c_str(), "rb");
     if (f == NULL) {
       *result = NULL;
-      RecordErrorAt(kNewSequentialFile);
-      return Status::IOError(fname, strerror(errno));
+      int saved_errno = errno;
+      RecordSpecificError(kNewSequentialFile, saved_errno);
+      return Status::IOError(fname, strerror(saved_errno));
     } else {
       *result = new ChromiumSequentialFile(fname, f, this);
       return Status::OK();
     }
   }
 
   virtual Status NewRandomAccessFile(const std::string& fname,
                                      RandomAccessFile** result) {
     int flags = ::base::PLATFORM_FILE_READ | ::base::PLATFORM_FILE_OPEN;
     bool created;
@@ skipping 210 matching lines @@
     }
     *path = FilePathToString(test_directory_);
     mu_.Release();
     return Status::OK();
   }
 
   virtual Status NewLogger(const std::string& fname, Logger** result) {
     FILE* f = fopen_internal(fname.c_str(), "w");
     if (f == NULL) {
       *result = NULL;
-      RecordErrorAt(kNewLogger);
-      return Status::IOError(fname, strerror(errno));
+      int saved_errno = errno;
+      RecordSpecificError(kNewLogger, saved_errno);
+      return Status::IOError(fname, strerror(saved_errno));
     } else {
       if (!sync_parent(fname)) {
         fclose(f);
         return Status::IOError(fname, strerror(errno));
       }
       *result = new ChromiumLogger(f);
       return Status::OK();
     }
   }
 
@@ skipping 94 matching lines @@
 }
 
 void ChromiumEnv::InitHistograms(const std::string& uma_title) {
   std::string uma_name(uma_title);
   uma_name.append(".IOError");
   io_error_histogram_ = base::LinearHistogram::FactoryGet(uma_name, 1,
       kNumEntries, kNumEntries + 1, base::Histogram::kUmaTargetedHistogramFlag);
 
   uma_name.append(".");
   MakeErrnoHistogram(uma_name, kWritableFileAppend);
+  MakeErrnoHistogram(uma_name, kNewSequentialFile);
+  MakeErrnoHistogram(uma_name, kWritableFileFlush);
+  MakeErrnoHistogram(uma_name, kNewLogger);
   MakePlatformFileErrorHistogram(uma_name, kNewRandomAccessFile);
   MakePlatformFileErrorHistogram(uma_name, kLockFile);
 
   const int kBucketSizeMillis = 25;
   // Add 2, 1 for each of the buckets <1 and >max.
   const int kNumBuckets = kMaxRenameTimeMillis / kBucketSizeMillis + 2;
 
   std::string retry_name(uma_title);
   retry_name.append(".TimeToRename");
   rename_time_histogram_ = base::LinearHistogram::FactoryTimeGet(
@@ skipping 91 matching lines @@
 
 Env* IDBEnv() {
   return idb_env.Pointer();
 }
 
 Env* Env::Default() {
   return default_env.Pointer();
 }
 
 }