chrome/browser/ui/toolbar/back_forward_menu_model.cc - Issue 1381633002: Cleanup: IWYU for browser_navigator.h and browser_navigator_params.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/back_forward_menu_model.cc

Issue 1381633002: Cleanup: IWYU for browser_navigator.h and browser_navigator_params.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, fix merge conflict Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_starter.cc ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/back_forward_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/back_forward_menu_model.cc b/chrome/browser/ui/toolbar/back_forward_menu_model.cc

index 15d58e7e35532c9a6b5ce2bab6d70e1719ccb069..2fff7c07136b350ad427a077b3b91a2c6d5f0fec 100644

--- a/chrome/browser/ui/toolbar/back_forward_menu_model.cc

+++ b/chrome/browser/ui/toolbar/back_forward_menu_model.cc

@@ -13,6 +13,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

+#include "chrome/browser/ui/browser_navigator_params.h"

#include "chrome/browser/ui/singleton_tabs.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/pref_names.h"

@@ -467,7 +468,7 @@ NavigationEntry* BackForwardMenuModel::GetNavigationEntry(int index) const {

std::string BackForwardMenuModel::BuildActionName(

const std::string& action, int index) const {

DCHECK(!action.empty());

- DCHECK(index >= -1);

+ DCHECK_GE(index, -1);

std::string metric_string;

if (model_type_ == FORWARD_MENU)

metric_string += "ForwardMenu_";