Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: chrome/browser/ui/toolbar/back_forward_menu_model.cc

Issue 1381633002: Cleanup: IWYU for browser_navigator.h and browser_navigator_params.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, fix merge conflict Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/back_forward_menu_model.h" 5 #include "chrome/browser/ui/toolbar/back_forward_menu_model.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
11 #include "build/build_config.h" 11 #include "build/build_config.h"
12 #include "chrome/browser/favicon/favicon_service_factory.h" 12 #include "chrome/browser/favicon/favicon_service_factory.h"
13 #include "chrome/browser/profiles/profile.h" 13 #include "chrome/browser/profiles/profile.h"
14 #include "chrome/browser/ui/browser.h" 14 #include "chrome/browser/ui/browser.h"
15 #include "chrome/browser/ui/browser_commands.h" 15 #include "chrome/browser/ui/browser_commands.h"
16 #include "chrome/browser/ui/browser_navigator_params.h"
16 #include "chrome/browser/ui/singleton_tabs.h" 17 #include "chrome/browser/ui/singleton_tabs.h"
17 #include "chrome/browser/ui/tabs/tab_strip_model.h" 18 #include "chrome/browser/ui/tabs/tab_strip_model.h"
18 #include "chrome/common/pref_names.h" 19 #include "chrome/common/pref_names.h"
19 #include "chrome/common/url_constants.h" 20 #include "chrome/common/url_constants.h"
20 #include "chrome/grit/generated_resources.h" 21 #include "chrome/grit/generated_resources.h"
21 #include "components/favicon_base/favicon_types.h" 22 #include "components/favicon_base/favicon_types.h"
22 #include "content/public/browser/favicon_status.h" 23 #include "content/public/browser/favicon_status.h"
23 #include "content/public/browser/navigation_controller.h" 24 #include "content/public/browser/navigation_controller.h"
24 #include "content/public/browser/navigation_entry.h" 25 #include "content/public/browser/navigation_entry.h"
25 #include "content/public/browser/user_metrics.h" 26 #include "content/public/browser/user_metrics.h"
(...skipping 434 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 if (controller_index >= 0 && controller_index < controller.GetEntryCount()) 461 if (controller_index >= 0 && controller_index < controller.GetEntryCount())
461 return controller.GetEntryAtIndex(controller_index); 462 return controller.GetEntryAtIndex(controller_index);
462 463
463 NOTREACHED(); 464 NOTREACHED();
464 return NULL; 465 return NULL;
465 } 466 }
466 467
467 std::string BackForwardMenuModel::BuildActionName( 468 std::string BackForwardMenuModel::BuildActionName(
468 const std::string& action, int index) const { 469 const std::string& action, int index) const {
469 DCHECK(!action.empty()); 470 DCHECK(!action.empty());
470 DCHECK(index >= -1); 471 DCHECK_GE(index, -1);
471 std::string metric_string; 472 std::string metric_string;
472 if (model_type_ == FORWARD_MENU) 473 if (model_type_ == FORWARD_MENU)
473 metric_string += "ForwardMenu_"; 474 metric_string += "ForwardMenu_";
474 else 475 else
475 metric_string += "BackMenu_"; 476 metric_string += "BackMenu_";
476 metric_string += action; 477 metric_string += action;
477 if (index != -1) { 478 if (index != -1) {
478 // +1 is for historical reasons (indices used to start at 1). 479 // +1 is for historical reasons (indices used to start at 1).
479 metric_string += base::IntToString(index + 1); 480 metric_string += base::IntToString(index + 1);
480 } 481 }
481 return metric_string; 482 return metric_string;
482 } 483 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698