Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 13811013: Refactor FileSystemMountPointProvider::CreateFileStream{Reader,Writer} (Closed)

Created:
7 years, 8 months ago by nhiroki
Modified:
7 years, 8 months ago
Reviewers:
kinuko, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, calvinlo
Visibility:
Public.

Description

Refactor FileSystemMountPointProvider::CreateFileStream{Reader,Writer} FileSystemMountPointProvider::CreateFileStream{Reader,Writer} should return scoped_ptr instead of raw pointer so that the caller can make sure it obtains the ownership of the returned Reader/Writer. BUG=175934 TEST=should pass all existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193354

Patch Set 1 #

Patch Set 2 : cros fix #

Patch Set 3 : rebase #

Patch Set 4 : conflict fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -53 lines) Patch
M webkit/blob/blob_url_request_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.cc View 1 3 chunks +13 lines, -8 lines 0 comments Download
M webkit/fileapi/file_system_context.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_context.cc View 1 2 3 2 chunks +9 lines, -6 lines 0 comments Download
M webkit/fileapi/file_system_mount_point_provider.h View 2 chunks +2 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M webkit/fileapi/test_mount_point_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/test_mount_point_provider.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M webkit/fileapi/upload_file_system_file_element_reader.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nhiroki
PTAL, thanks!
7 years, 8 months ago (2013-04-09 11:19:12 UTC) #1
kinuko
Looks good, can you also change webkit/chromeos/fileapi/cros_mount_point_provider.cc?
7 years, 8 months ago (2013-04-09 12:38:26 UTC) #2
nhiroki
Updated. Please take another look. Thanks! On 2013/04/09 12:38:26, kinuko wrote: > Looks good, can ...
7 years, 8 months ago (2013-04-10 02:20:36 UTC) #3
tzik
lgtm
7 years, 8 months ago (2013-04-10 03:50:21 UTC) #4
nhiroki
Sorry, this patch still has problems. I'll fix them soon...
7 years, 8 months ago (2013-04-10 04:27:25 UTC) #5
nhiroki
On 2013/04/10 04:27:25, nhiroki wrote: > Sorry, this patch still has problems. I'll fix them ...
7 years, 8 months ago (2013-04-10 05:31:29 UTC) #6
kinuko
lgtm
7 years, 8 months ago (2013-04-10 05:53:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/13811013/37001
7 years, 8 months ago (2013-04-10 06:12:56 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 09:17:06 UTC) #9
Message was sent while issue was closed.
Change committed as 193354

Powered by Google App Engine
This is Rietveld 408576698