Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: webkit/chromeos/fileapi/cros_mount_point_provider.cc

Issue 13811013: Refactor FileSystemMountPointProvider::CreateFileStream{Reader,Writer} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: conflict fix Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/chromeos/fileapi/cros_mount_point_provider.h ('k') | webkit/fileapi/file_system_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/chromeos/fileapi/cros_mount_point_provider.cc
diff --git a/webkit/chromeos/fileapi/cros_mount_point_provider.cc b/webkit/chromeos/fileapi/cros_mount_point_provider.cc
index 550bb61bddc9b3d143288c14decaa0247943d207..11cf6f778b76a6bc035035db8d0f13bb254dd68a 100644
--- a/webkit/chromeos/fileapi/cros_mount_point_provider.cc
+++ b/webkit/chromeos/fileapi/cros_mount_point_provider.cc
@@ -279,7 +279,8 @@ fileapi::FileSystemOperation* CrosMountPointProvider::CreateFileSystemOperation(
operation_context.Pass());
}
-webkit_blob::FileStreamReader* CrosMountPointProvider::CreateFileStreamReader(
+scoped_ptr<webkit_blob::FileStreamReader>
+CrosMountPointProvider::CreateFileStreamReader(
const fileapi::FileSystemURL& url,
int64 offset,
const base::Time& expected_modification_time,
@@ -287,11 +288,13 @@ webkit_blob::FileStreamReader* CrosMountPointProvider::CreateFileStreamReader(
// For now we return a generic Reader implementation which utilizes
// CreateSnapshotFile internally (i.e. will download everything first).
// TODO(satorux,zel): implement more efficient reader for remote cases.
- return new fileapi::FileSystemFileStreamReader(
- context, url, offset, expected_modification_time);
+ return scoped_ptr<webkit_blob::FileStreamReader>(
+ new fileapi::FileSystemFileStreamReader(
+ context, url, offset, expected_modification_time));
}
-fileapi::FileStreamWriter* CrosMountPointProvider::CreateFileStreamWriter(
+scoped_ptr<fileapi::FileStreamWriter>
+CrosMountPointProvider::CreateFileStreamWriter(
const fileapi::FileSystemURL& url,
int64 offset,
fileapi::FileSystemContext* context) const {
@@ -301,15 +304,17 @@ fileapi::FileStreamWriter* CrosMountPointProvider::CreateFileStreamWriter(
fileapi::RemoteFileSystemProxyInterface* remote_proxy =
GetRemoteProxy(url.filesystem_id());
if (!remote_proxy)
- return NULL;
- return new fileapi::RemoteFileStreamWriter(remote_proxy, url, offset);
+ return scoped_ptr<fileapi::FileStreamWriter>();
+ return scoped_ptr<fileapi::FileStreamWriter>(
+ new fileapi::RemoteFileStreamWriter(remote_proxy, url, offset));
}
if (url.type() == fileapi::kFileSystemTypeRestrictedNativeLocal)
- return NULL;
+ return scoped_ptr<fileapi::FileStreamWriter>();
DCHECK(url.type() == fileapi::kFileSystemTypeNativeLocal);
- return new fileapi::LocalFileStreamWriter(url.path(), offset);
+ return scoped_ptr<fileapi::FileStreamWriter>(
+ new fileapi::LocalFileStreamWriter(url.path(), offset));
}
bool CrosMountPointProvider::GetVirtualPath(
« no previous file with comments | « webkit/chromeos/fileapi/cros_mount_point_provider.h ('k') | webkit/fileapi/file_system_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698