Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1380833003: Delete IDC_CONTENT_CONTEXT_ADDSEARCHENGINE (Closed)

Created:
5 years, 2 months ago by Evan Stade
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete IDC_CONTENT_CONTEXT_ADDSEARCHENGINE This is no longer used anywhere. I'll follow up by removing the dialog code it invoked. BUG=506874, 521128 TBR=grt@chromium.org Committed: https://crrev.com/fd8287c764243143108211b078347466c4f6a327 Cr-Commit-Position: refs/heads/master@{#352103}

Patch Set 1 #

Total comments: 2

Patch Set 2 : one less include #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 4 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Evan Stade
5 years, 2 months ago (2015-09-30 18:57:25 UTC) #2
edwardjung
LGTM, thanks for picking this up. It did slip my mind to update the bug ...
5 years, 2 months ago (2015-09-30 20:06:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380833003/1
5 years, 2 months ago (2015-09-30 22:18:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/105429)
5 years, 2 months ago (2015-09-30 22:31:51 UTC) #7
Evan Stade
OWNERS, please review: avi: render_view_context_menu.cc grt: chrome_command_ids.h
5 years, 2 months ago (2015-10-01 00:37:28 UTC) #9
Avi (use Gerrit)
LGTM with additional removal. https://chromiumcodereview.appspot.com/1380833003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://chromiumcodereview.appspot.com/1380833003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode55 chrome/browser/renderer_context_menu/render_view_context_menu.cc:55: #include "chrome/browser/ui/search_engines/search_engine_tab_helper.h" You can probably ...
5 years, 2 months ago (2015-10-01 00:41:35 UTC) #10
Evan Stade
https://codereview.chromium.org/1380833003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/1380833003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode55 chrome/browser/renderer_context_menu/render_view_context_menu.cc:55: #include "chrome/browser/ui/search_engines/search_engine_tab_helper.h" On 2015/10/01 00:41:35, Avi wrote: > You ...
5 years, 2 months ago (2015-10-01 17:48:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380833003/20001
5 years, 2 months ago (2015-10-01 17:49:50 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/115182)
5 years, 2 months ago (2015-10-01 19:03:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380833003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380833003/40001
5 years, 2 months ago (2015-10-02 18:54:19 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-02 19:51:11 UTC) #22
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 19:52:19 UTC) #23
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fd8287c764243143108211b078347466c4f6a327
Cr-Commit-Position: refs/heads/master@{#352103}

Powered by Google App Engine
This is Rietveld 408576698