Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1378193002: Devtools[LayoutEditor]: Keep LayoutEditor in sync with a node selected in ElementsPanel (Closed)

Created:
5 years, 2 months ago by sergeyv
Modified:
5 years, 2 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools[LayoutEditor]: Keep LayoutEditor in sync with a node selected in ElementsPanel BUG=501896 Committed: https://crrev.com/eefe560eb9d4ae5f8f9564a7ccbac42e0869719c Cr-Commit-Position: refs/heads/master@{#351694}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 2 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sergeyv
5 years, 2 months ago (2015-09-30 21:34:55 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1378193002/diff/1/third_party/WebKit/Source/web/InspectorOverlay.cpp File third_party/WebKit/Source/web/InspectorOverlay.cpp (right): https://codereview.chromium.org/1378193002/diff/1/third_party/WebKit/Source/web/InspectorOverlay.cpp#newcode346 third_party/WebKit/Source/web/InspectorOverlay.cpp:346: overlayClearSelection(true); Replace with commit, dispose and clear.
5 years, 2 months ago (2015-09-30 23:13:34 UTC) #3
sergeyv
https://chromiumcodereview.appspot.com/1378193002/diff/1/third_party/WebKit/Source/web/InspectorOverlay.cpp File third_party/WebKit/Source/web/InspectorOverlay.cpp (right): https://chromiumcodereview.appspot.com/1378193002/diff/1/third_party/WebKit/Source/web/InspectorOverlay.cpp#newcode346 third_party/WebKit/Source/web/InspectorOverlay.cpp:346: overlayClearSelection(true); On 2015/09/30 23:13:34, dgozman wrote: > Replace with ...
5 years, 2 months ago (2015-09-30 23:35:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378193002/20001
5 years, 2 months ago (2015-09-30 23:36:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 01:10:23 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 01:12:01 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/eefe560eb9d4ae5f8f9564a7ccbac42e0869719c
Cr-Commit-Position: refs/heads/master@{#351694}

Powered by Google App Engine
This is Rietveld 408576698