mus: move View Manager to components/mus/vm

mus: move View Manager to components/mus/vm

In order to disambiguate view_manager classes from non-
view_manager classes, I've moved view_manager code to
components/mus/vm.

BUG=531533
TBR=jam@chromium.org for trivial pdf_viewer change.

Committed: https://crrev.com/1b99651bdfe4303f66342487ef88132ddc5b553f
Cr-Commit-Position: refs/heads/master@{#351667}

[Fady Samuel, 2015-09-28 18:08:09]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-09-28 19:10:35]

sky@chromium.org changed reviewers:
+ ben@chromium.org

[sky, 2015-09-28 19:10:36]

It seems like what we have in the public directory (components/mus/public...) is
mus to the external world (meaning anyone consuming mus). Creating the directory
components/mus/vm is good from the perspective of better structuring the code,
but I think that's an implementation and shouldn't impact the public parts. In
other words I think we should leave components/mus/public along and only move
the server parts into components/mus/vm.

+ben for his thoughts.

[Ben Goodger (Google), 2015-09-28 21:17:21]

also if we're going to be thrashing this many files I think we should resolve
the View naming issue. if not in this CL then at least settle on it.

[Fady Samuel, 2015-09-28 21:43:26]

On 2015/09/28 21:17:21, Ben Goodger (Google) wrote:
> also if we're going to be thrashing this many files I think we should resolve
> the View naming issue. if not in this CL then at least settle on it.

Happy to rename this to whatever we decide on. I'm personally fairly
indifferent.

[Ben Goodger (Google), 2015-09-28 21:48:59]

btw to sky's point i think it makes sense for mus to have a toplevel public
dir with all the public interfaces.

i think it'd be slightly less confusing (maybe) for Views to be Windows,
since we already host views::Views.

I know we have aura::Windows but in the long term I think those are made
obsolete by the Mus types.

-Ben

On Mon, Sep 28, 2015 at 2:43 PM, <fsamuel@chromium.org> wrote:

> On 2015/09/28 21:17:21, Ben Goodger (Google) wrote:
>
>> also if we're going to be thrashing this many files I think we should
>> resolve
>> the View naming issue. if not in this CL then at least settle on it.
>>
>
> Happy to rename this to whatever we decide on. I'm personally fairly
> indifferent.
>
> https://codereview.chromium.org/1377493002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Fady Samuel, 2015-09-28 22:52:02]

PTAL Scott, I've moved public back to where it was.

[Fady Samuel, 2015-09-28 22:53:36]

On 2015/09/28 22:52:02, Fady Samuel wrote:
> PTAL Scott, I've moved public back to where it was.

I'll rename views to windows in a separate CL since that's a fairly ginormous
change.

[sky, 2015-09-29 16:10:20]

LGTM

[Fady Samuel, 2015-09-29 19:13:24]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2015-09-29 19:14:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377493002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377493002/60001

[commit-bot: I haz the power, 2015-09-29 19:21:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 19:21:53]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2015-09-29 21:09:33]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-09-29 21:09:34]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1377493002/#ps80001
(title: "Rebased + Fixed mus DEPS")

[commit-bot: I haz the power, 2015-09-29 21:10:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377493002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377493002/80001

[commit-bot: I haz the power, 2015-09-29 21:17:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 21:17:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Fady Samuel, 2015-09-29 21:54:59]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-09-29 21:55:00]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1377493002/#ps100001
(title: "Another try")

[commit-bot: I haz the power, 2015-09-29 22:03:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377493002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377493002/100001

[commit-bot: I haz the power, 2015-09-29 22:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 22:21:47]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Fady Samuel, 2015-09-29 22:23:11]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-09-29 22:23:12]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1377493002/#ps120001
(title: "More deps")

[commit-bot: I haz the power, 2015-09-29 22:24:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377493002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377493002/120001

[commit-bot: I haz the power, 2015-09-29 22:32:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 22:32:06]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Fady Samuel, 2015-09-29 22:45:31]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-09-29 22:45:31]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1377493002/#ps140001
(title: "Rebased")

[commit-bot: I haz the power, 2015-09-29 22:46:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377493002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377493002/140001

[commit-bot: I haz the power, 2015-09-29 22:54:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 22:54:41]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Fady Samuel, 2015-09-30 04:41:44]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-09-30 04:41:45]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1377493002/#ps160001
(title: "Rebased + Fixed Android build")

[commit-bot: I haz the power, 2015-09-30 04:42:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377493002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377493002/160001

[Fady Samuel, 2015-09-30 04:46:24]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2015-09-30 04:46:36]

fsamuel@chromium.org changed reviewers:
+ jam@chromium.org

[Fady Samuel, 2015-09-30 04:46:38]

+jam@ for pdf_viewer change.

[Fady Samuel, 2015-09-30 15:21:20]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-09-30 15:21:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1377493002/#ps180001
(title: "Rebased + fixed BUILD")

[commit-bot: I haz the power, 2015-09-30 15:22:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377493002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377493002/180001

[Fady Samuel, 2015-09-30 16:36:11]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-09-30 16:36:12]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1377493002/#ps200001
(title: "Remove unnecessary dependency in pdf_viewer BUILD.gn")

[commit-bot: I haz the power, 2015-09-30 16:37:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377493002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377493002/200001

[jam, 2015-09-30 16:59:14]

On 2015/09/30 04:46:38, Fady Samuel wrote:
> +jam@ for pdf_viewer change.

lgtm

[commit-bot: I haz the power, 2015-09-30 17:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 17:34:38]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2015-09-30 18:07:01]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-09-30 18:07:02]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1377493002/#ps220001
(title: "Fixed DEPS")

[commit-bot: I haz the power, 2015-09-30 18:08:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377493002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377493002/220001

[Ben Goodger (Google), 2015-09-30 18:09:24]

btw for the record,

Scott & I like

mus::Window
and "ws" (Window Service/Server)

as names.

-Ben

On Wed, Sep 30, 2015 at 11:08 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1377493002/220001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1377493002/220001
>
>
> https://codereview.chromium.org/1377493002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-09-30 18:15:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 18:15:48]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Fady Samuel, 2015-09-30 18:24:22]

On 2015/09/30 18:09:24, Ben Goodger (Google) wrote:
> btw for the record,
> 
> Scott & I like
> 
> mus::Window
> and "ws" (Window Service/Server)
> 
> as names.
> 
> -Ben
> 
> On Wed, Sep 30, 2015 at 11:08 AM, mailto:commit-bot@chromium.org via
> http://codereview.chromium.org
<mailto:reply@chromiumcodereview-hr.appspotmail.com> wrote:
> 
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/1377493002/220001
> > View timeline at
> >  https://chromium-cq-status.appspot.com/patch-timeline/1377493002/220001
> >
> >
> > https://codereview.chromium.org/1377493002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

OK, more moving/renaming/refactoring CLs coming in the near future :-)

[Fady Samuel, 2015-09-30 18:25:49]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2015-09-30 18:27:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377493002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377493002/220001

[commit-bot: I haz the power, 2015-09-30 18:40:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 18:40:45]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Fady Samuel, 2015-09-30 22:04:01]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-09-30 22:04:02]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
sky@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1377493002/#ps240001 (title: "Rebased")

[commit-bot: I haz the power, 2015-09-30 22:06:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377493002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377493002/240001

[commit-bot: I haz the power, 2015-09-30 22:16:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 22:16:33]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Fady Samuel, 2015-09-30 22:21:34]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2015-09-30 22:22:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377493002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377493002/240001

[commit-bot: I haz the power, 2015-09-30 22:49:34]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2015-09-30 22:50:50]

Patchset 13 (id:??) landed as
https://crrev.com/1b99651bdfe4303f66342487ef88132ddc5b553f
Cr-Commit-Position: refs/heads/master@{#351667}