Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 13774005: Remove the ENABLE_SQL_DATABASE compile-time flag. (Closed)

Created:
7 years, 8 months ago by Mike West
Modified:
7 years, 8 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, gavinp+loader_chromium.org, haraken, Nate Chapin, eseidel1, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Remove the ENABLE_SQL_DATABASE compile-time flag. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147911

Patch Set 1 #

Patch Set 2 : python #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -509 lines) Patch
M Source/WTF/wtf/FeatureDefines.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/AbstractDatabaseServer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/AbstractSQLStatement.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/AbstractSQLStatementBackend.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/AbstractSQLTransaction.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/AbstractSQLTransactionBackend.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/ChangeVersionData.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/ChangeVersionWrapper.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/ChangeVersionWrapper.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/Database.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/Database.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/Database.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseBackend.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseBackend.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseBackendBase.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseBackendContext.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseBackendContext.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseBackendSync.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseBackendSync.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseBase.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseBase.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseBasicTypes.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseCallback.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseContext.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseContext.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseDetails.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseError.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseManager.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseManager.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseManagerClient.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseServer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseServer.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseSync.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseSync.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseSync.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseTask.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseTask.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseThread.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseThread.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseTracker.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/OriginLock.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/OriginLock.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLCallbackWrapper.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLError.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLError.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLException.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLException.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLException.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLResultSet.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLResultSet.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLResultSet.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLResultSetRowList.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLResultSetRowList.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLResultSetRowList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLStatement.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLStatement.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLStatementBackend.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLStatementCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLStatementCallback.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLStatementErrorCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLStatementErrorCallback.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLStatementSync.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLStatementSync.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransaction.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransaction.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransaction.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionBackendSync.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionBackendSync.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionCallback.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionClient.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionClient.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionCoordinator.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionCoordinator.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionErrorCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionErrorCallback.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionState.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionStateMachine.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionStateMachine.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionSync.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionSync.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionSync.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionSyncCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionSyncCallback.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/chromium/DatabaseObserver.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/chromium/QuotaTracker.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/chromium/QuotaTracker.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/scripts/test/TestCallback.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/bindings/scripts/test/V8/V8TestCallback.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/bindings/scripts/test/V8/V8TestCallback.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8SQLTransactionCustom.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/dom/DOMExceptions.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/dom/ScriptExecutionContext.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/dom/ScriptExecutionContext.cpp View 3 chunks +1 line, -6 lines 0 comments Download
M Source/WebCore/history/PageCache.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/CodeGeneratorInspector.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/inspector/InjectedScriptHost.h View 4 chunks +0 lines, -8 lines 0 comments Download
M Source/WebCore/inspector/InjectedScriptHost.cpp View 5 chunks +1 line, -9 lines 0 comments Download
M Source/WebCore/inspector/InspectorController.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorDatabaseAgent.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorDatabaseAgent.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorDatabaseInstrumentation.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorDatabaseResource.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/InspectorDatabaseResource.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorInstrumentation.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorInstrumentation.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InstrumentingAgents.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InstrumentingAgents.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/WorkerInspectorController.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/loader/EmptyClients.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/loader/FrameLoader.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/page/ChromeClient.h View 3 chunks +1 line, -5 lines 0 comments Download
M Source/WebCore/workers/WorkerThread.cpp View 5 chunks +2 lines, -10 lines 0 comments Download
M Source/WebKit/chromium/features.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/src/ChromeClientImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/ChromeClientImpl.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/DatabaseObserver.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/WebDatabase.cpp View 2 chunks +0 lines, -21 lines 0 comments Download
M Source/WebKit/chromium/src/WebRuntimeFeatures.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
This got big. :/ SQL_DATABASE was enabled by default, but could be disabled via a ...
7 years, 8 months ago (2013-04-08 09:32:56 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 8 months ago (2013-04-08 09:36:31 UTC) #2
Mike West
On 2013/04/08 09:36:31, jochen wrote: > lgtm I missed a Python generator: New tryjobs up ...
7 years, 8 months ago (2013-04-08 12:48:10 UTC) #3
Mike West
On 2013/04/08 12:48:10, Mike West (chromium) wrote: > On 2013/04/08 09:36:31, jochen wrote: > > ...
7 years, 8 months ago (2013-04-08 18:10:01 UTC) #4
Mike West
7 years, 8 months ago (2013-04-09 08:20:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r147911 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698