Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 13772003: Move bindings/generic/* to bindings/v8/ (Closed)

Created:
7 years, 8 months ago by haraken
Modified:
7 years, 8 months ago
CC:
blink-reviews, Nate Chapin
Visibility:
Public.

Description

Move bindings/generic/* to bindings/v8/ Now V8 is the only JS engine supported in Chrome, we don't need to keep a concept of 'generic' that has existed to share code between JSC and V8. BUG=none TEST=none R=abarth,eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -969 lines) Patch
M Source/WebCore/WebCore.gypi View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/WebCore/WebCore.gyp/WebCore.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
D Source/WebCore/bindings/generic/ActiveDOMCallback.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/WebCore/bindings/generic/ActiveDOMCallback.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
D Source/WebCore/bindings/generic/BindingSecurity.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/WebCore/bindings/generic/BindingSecurity.cpp View 1 chunk +0 lines, -83 lines 0 comments Download
D Source/WebCore/bindings/generic/GenericBinding.h View 1 chunk +0 lines, -50 lines 0 comments Download
D Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h View 1 chunk +0 lines, -408 lines 0 comments Download
D Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp View 1 chunk +0 lines, -238 lines 0 comments Download
A + Source/WebCore/bindings/v8/ActiveDOMCallback.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/WebCore/bindings/v8/ActiveDOMCallback.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/WebCore/bindings/v8/BindingSecurity.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/WebCore/bindings/v8/BindingSecurity.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/WebCore/bindings/v8/GenericBinding.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/WebCore/bindings/v8/RuntimeEnabledFeatures.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/WebCore/bindings/v8/RuntimeEnabledFeatures.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
haraken
7 years, 8 months ago (2013-04-08 08:15:04 UTC) #1
dglazkov
LGTM.
7 years, 8 months ago (2013-04-08 14:31:42 UTC) #2
abarth-chromium
Yeah, we can also clean up this code to be less abstract, but that's something ...
7 years, 8 months ago (2013-04-08 17:00:52 UTC) #3
haraken
7 years, 8 months ago (2013-04-09 01:17:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r147887 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698