Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 137713002: Get rid of custom bindings for V8NodeList (Closed)

Created:
5 years, 2 months ago by Inactive
Modified:
5 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Get rid of custom bindings for V8NodeList Get rid of custom bindings for V8NodeList by generating visitDOMWrapper() and adding an ownerNode() method to the NodeList class. This method calls LiveNodeList::ownerNode() if the NodeList is live, and returns null otherwise. There is no web-exposed change in behavior. R=haraken BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165034

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -62 lines) Patch
M Source/bindings/bindings.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D Source/bindings/v8/custom/V8NodeListCustom.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
M Source/core/dom/LiveNodeList.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/NodeList.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/NodeList.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M Source/core/dom/NodeList.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
For reference, the generated code looks like: void V8NodeList::visitDOMWrapper(void* object, const v8::Persistent<v8::Object>& wrapper, v8::Isolate* isolate) ...
5 years, 2 months ago (2014-01-14 01:36:42 UTC) #1
haraken
LGTM. Great.
5 years, 2 months ago (2014-01-14 01:39:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137713002/40001
5 years, 2 months ago (2014-01-14 03:11:29 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2014-01-14 06:46:57 UTC) #4
Message was sent while issue was closed.
Change committed as 165034

Powered by Google App Engine
This is Rietveld 408576698