Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1375693002: Move status bar color setting to ChromeActivity. (Closed)

Created:
5 years, 2 months ago by aurimas (slooooooooow)
Modified:
5 years, 2 months ago
Reviewers:
Ted C, Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move status bar color setting to ChromeActivity. Relanding https://codereview.chromium.org/1364043003/ after fixing Svelte crash and CustomTabs test failure. - Svelte was crashing due to getActivityTab being null when onOverviewModeFinishedHiding is called. - CustomTabsActivity sets the status bar color explicitly and does not need to inherit setStatusBarColor calls from ChromeActivity. BUG=535235, 536698 Committed: https://crrev.com/ea566c8cf38dfcf6564ac0c8994b832736e99a8a Cr-Commit-Position: refs/heads/master@{#351182}

Patch Set 1 #

Patch Set 2 : Update test to check for status bar color #

Messages

Total messages: 13 (5 generated)
aurimas (slooooooooow)
PTAL
5 years, 2 months ago (2015-09-28 18:56:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375693002/1
5 years, 2 months ago (2015-09-28 19:45:48 UTC) #4
Yusuf
lgtm
5 years, 2 months ago (2015-09-28 20:01:32 UTC) #5
aurimas (slooooooooow)
+tedchoc for OWNERS review.
5 years, 2 months ago (2015-09-28 20:26:04 UTC) #7
Ted C
lgtm
5 years, 2 months ago (2015-09-28 21:14:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375693002/20001
5 years, 2 months ago (2015-09-28 21:15:10 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 22:44:08 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 22:45:55 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea566c8cf38dfcf6564ac0c8994b832736e99a8a
Cr-Commit-Position: refs/heads/master@{#351182}

Powered by Google App Engine
This is Rietveld 408576698