Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 1375693002: Move status bar color setting to ChromeActivity. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update test to check for status bar color Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 7e7c2762665f0c43a5521796bf108f3513ffcd2e..70be34d8ee1eb4cdec8227b3ecc5003a654320a8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -9,6 +9,7 @@ import android.app.ActivityManager;
import android.app.SearchManager;
import android.content.Context;
import android.content.Intent;
+import android.graphics.Color;
import android.os.Build;
import android.os.Bundle;
import android.os.SystemClock;
@@ -21,6 +22,7 @@ import android.view.Window;
import android.view.WindowManager;
import android.widget.FrameLayout;
+import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.CommandLine;
import org.chromium.base.Log;
import org.chromium.base.MemoryPressureListener;
@@ -1262,16 +1264,26 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
public void onOverviewModeStartedShowing(boolean showToolbar) {
if (mFindToolbarManager != null) mFindToolbarManager.hideToolbar();
if (getAssistStatusHandler() != null) getAssistStatusHandler().updateAssistState();
+ ApiCompatibilityUtils.setStatusBarColor(getWindow(), Color.BLACK);
}
@Override
public void onOverviewModeFinishedShowing() {}
@Override
- public void onOverviewModeStartedHiding(boolean showToolbar, boolean delayAnimation) {}
+ public void onOverviewModeStartedHiding(boolean showToolbar, boolean delayAnimation) {
+ }
@Override
public void onOverviewModeFinishedHiding() {
if (getAssistStatusHandler() != null) getAssistStatusHandler().updateAssistState();
+ if (getActivityTab() != null) {
+ setStatusBarColor(getActivityTab(), getActivityTab().getThemeColor());
+ }
+ }
+
+ @Override
+ protected void setStatusBarColor(Tab tab, int color) {
+ super.setStatusBarColor(tab, isInOverviewMode() ? Color.BLACK : color);
}
}

Powered by Google App Engine
This is Rietveld 408576698