Use the event-handler for timers.

Use the event-handler for timers.

BUG=
R=ager@google.com

Committed: https://github.com/dart-lang/fletch/commit/bb5ade404f6fdab8c962137374a25d73e5f77856

[Anders Johnsen, 2015-09-30 22:43:14]

ajohnsen@google.com changed reviewers:
+ ager@google.com, herhut@google.com

[Anders Johnsen, 2015-09-30 22:43:15]

Only Linux for now. Will do Mac once we are happy.

[Mads Ager (google), 2015-10-01 14:08:37]

Looks good for the linux part. Lots of room for improvement, but it is great to
get this into the eventhandler. :)

https://chromiumcodereview.appspot.com/1375373004/diff/1/src/vm/event_handler...
File src/vm/event_handler_linux.cc (right):

https://chromiumcodereview.appspot.com/1375373004/diff/1/src/vm/event_handler...
src/vm/event_handler_linux.cc:64: while (true) {
Would this be easier to read if it was a do-while?

bool found = false;
do {
  for (...) {
    ...
  }
} while (found);

Maybe add a comment that you are doing the O(n^2) iteration here to avoid
modification during iteration on the hashmap.

https://chromiumcodereview.appspot.com/1375373004/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://chromiumcodereview.appspot.com/1375373004/diff/1/tests/lib/lib.status...
tests/lib/lib.status:47: async/stream_type_test: RuntimeError
What made this fail now?

[kustermann, 2015-10-01 17:03:54]

kustermann@google.com changed reviewers:
+ kustermann@google.com

[kustermann, 2015-10-01 17:03:54]

This is really great :)

Haven't looked at the code, but this is really needed. In particular you might
want to get rid of all 'os.sleep()' calls and replace them with this timer
usage. The 'os.sleep()' is really horrible, since it's implemented in terms of
'dart:ffi' which will block a scheduler worker thread (and can therefore stall
the whole VM).

+1

[Anders Johnsen, 2015-10-02 00:25:15]

PTAL

https://chromiumcodereview.appspot.com/1375373004/diff/1/src/vm/event_handler...
File src/vm/event_handler_linux.cc (right):

https://chromiumcodereview.appspot.com/1375373004/diff/1/src/vm/event_handler...
src/vm/event_handler_linux.cc:64: while (true) {
On 2015/10/01 14:08:37, Mads Ager (google) wrote:
> Would this be easier to read if it was a do-while?
> 
> bool found = false;
> do {
>   for (...) {
>     ...
>   }
> } while (found);
> 
> Maybe add a comment that you are doing the O(n^2) iteration here to avoid
> modification during iteration on the hashmap.

I need to reset found to false, so sadly not a real gain. Added comment.

https://chromiumcodereview.appspot.com/1375373004/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://chromiumcodereview.appspot.com/1375373004/diff/1/tests/lib/lib.status...
tests/lib/lib.status:47: async/stream_type_test: RuntimeError
On 2015/10/01 14:08:37, Mads Ager (google) wrote:
> What made this fail now?

New test from recent dart roll

[Mads Ager (google), 2015-10-02 14:58:59]

LGTM

https://chromiumcodereview.appspot.com/1375373004/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://chromiumcodereview.appspot.com/1375373004/diff/1/tests/lib/lib.status...
tests/lib/lib.status:47: async/stream_type_test: RuntimeError
On 2015/10/02 00:25:15, Anders Johnsen wrote:
> On 2015/10/01 14:08:37, Mads Ager (google) wrote:
> > What made this fail now?
> 
> New test from recent dart roll

Does that mean that we are not running these tests on the bots?

[Anders Johnsen, 2015-10-02 15:19:53]

https://chromiumcodereview.appspot.com/1375373004/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://chromiumcodereview.appspot.com/1375373004/diff/1/tests/lib/lib.status...
tests/lib/lib.status:47: async/stream_type_test: RuntimeError
On 2015/10/02 14:58:59, Mads Ager (google) wrote:
> On 2015/10/02 00:25:15, Anders Johnsen wrote:
> > On 2015/10/01 14:08:37, Mads Ager (google) wrote:
> > > What made this fail now?
> > 
> > New test from recent dart roll
> 
> Does that mean that we are not running these tests on the bots?

Yep :/

[Anders Johnsen, 2015-10-02 15:19:56]

Committed patchset #3 (id:40001) manually as
bb5ade404f6fdab8c962137374a25d73e5f77856 (presubmit successful).