Issue 13741014: Do not systematically update the description on CL close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13741014: Do not systematically update the description on CL close. (Closed)

Created:
7 years, 8 months ago by M-A Ruel

Modified:
7 years, 8 months ago

Reviewers:
Dirk Pranke, dpranke

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

Do not systematically update the description on CL close. This is not always necessary, like for "git cl set_close". R=dpranke@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=192829

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	git_cl.py	View		2 chunks	+7 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

M-A Ruel

I have 3 preparatory CLs that I'll get committed before doing changes to the R= ...

7 years, 8 months ago (2013-04-08 17:47:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/13741014/1

7 years, 8 months ago (2013-04-08 17:55:24 UTC) #4

iannucci

7 years, 8 months ago (2013-04-08 18:02:19 UTC) #6

Message was sent while issue was closed.

On 2013/04/08 17:57:33, I haz the power (commit-bot) wrote:
> Change committed as 192829

+1 on this refactor, btw :)