Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: git_cl.py

Issue 13741014: Do not systematically update the description on CL close. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 338dd9327ed0bff6eefb5a47b14fea30377c29d2..16a6e0c402523988ed52ffdcde792fed340158c0 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -713,11 +713,14 @@ or verify this branch is set up to track another (via the --track argument to
('%s\nMaybe your depot_tools is out of date?\n'
'If all fails, contact maruel@') % e)
+ def UpdateDescription(self, description):
+ self.description = description
+ return self.RpcServer().update_description(
+ self.GetIssue(), self.description)
+
def CloseIssue(self):
"""Updates the description and closes the issue."""
- issue = self.GetIssue()
- self.RpcServer().update_description(issue, self.description)
- return self.RpcServer().close_issue(issue)
+ return self.RpcServer().close_issue(self.GetIssue())
def SetFlag(self, flag, value):
"""Patchset must match."""
@@ -1512,6 +1515,7 @@ def SendUpstream(parser, args, cmd):
cl.description += ('\n\nCommitted: ' + revision)
print ('Closing issue '
'(you may be prompted for your codereview password)...')
+ cl.UpdateDescription(cl.description)
cl.CloseIssue()
props = cl.RpcServer().get_issue_properties(cl.GetIssue(), False)
patch_num = len(props['patchsets'])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698