Basic analyzer `main()` isolate bootloader.

Basic analyzer `main()` isolate bootloader.

Plenty of refinement to come but this works.

Setup looks like this:

    Image image = new BootLoader().createImage(args);
    image.load();

Obviously names are provisional and integration tests to come.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/analyzer_cli/commit/fb6100af1361499feb9e973f01aa3a458c2f1cd1

[pquitslund, 2015-09-28 17:34:43]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-09-28 17:48:11]

LGTM

https://chromiumcodereview.appspot.com/1373953002/diff/1/lib/src/bootloader.dart
File lib/src/bootloader.dart (right):

https://chromiumcodereview.appspot.com/1373953002/diff/1/lib/src/bootloader.d...
lib/src/bootloader.dart:92: /// Create a loadable analyzer image confifgured
with plugins derived from
nit: "confifgured" --> "configured"

https://chromiumcodereview.appspot.com/1373953002/diff/1/lib/src/bootloader.d...
lib/src/bootloader.dart:113: List<OptionsProcessor> optionsProcessors =
I don't think there will be any processors until after we execute the generated
main in the child isolate.

[pquitslund, 2015-09-28 18:01:29]

https://chromiumcodereview.appspot.com/1373953002/diff/1/lib/src/bootloader.dart
File lib/src/bootloader.dart (right):

https://chromiumcodereview.appspot.com/1373953002/diff/1/lib/src/bootloader.d...
lib/src/bootloader.dart:92: /// Create a loadable analyzer image confifgured
with plugins derived from
On 2015/09/28 17:48:11, Brian Wilkerson wrote:
> nit: "confifgured" --> "configured"

Thanks!

https://chromiumcodereview.appspot.com/1373953002/diff/1/lib/src/bootloader.d...
lib/src/bootloader.dart:113: List<OptionsProcessor> optionsProcessors =
On 2015/09/28 17:48:11, Brian Wilkerson wrote:
> I don't think there will be any processors until after we execute the
generated
> main in the child isolate.

Actually, that's exactly what our PluginConfigOptionsProcessor is.  If we didn't
add options processors we wouldn't see the plugins configured in
`.analysis_options`.  Side note: if there end up being more plugins that want to
participate in bootstrapping we might want to make this explicit somehow.  In
this case PluginConfigOptionsProcessor should actually ONLY getting run in the
bootstrapping and not in the bootstrapped isolate.  Something to think about...

[pquitslund, 2015-09-28 18:08:49]

Committed patchset #1 (id:1) manually as
fb6100af1361499feb9e973f01aa3a458c2f1cd1 (presubmit successful).

[Brian Wilkerson, 2015-09-28 18:29:20]

https://chromiumcodereview.appspot.com/1373953002/diff/1/lib/src/bootloader.dart
File lib/src/bootloader.dart (right):

https://chromiumcodereview.appspot.com/1373953002/diff/1/lib/src/bootloader.d...
lib/src/bootloader.dart:113: List<OptionsProcessor> optionsProcessors =
> Actually, that's exactly what our PluginConfigOptionsProcessor is. If we
didn't
> add options processors we wouldn't see the plugins configured in
> `.analysis_options`.
>
> ...
>
> In this case PluginConfigOptionsProcessor should actually ONLY getting run in
the
> bootstrapping and not in the bootstrapped isolate.  Something to think
about...

So it's an explicitly installed "plugin" that can only be loaded during the
bootloading process? Doesn't sound much like a plugin, but OK. (I'd probably not
treat it like a plugin just to avoid confusing myself.)

> Side note: if there end up being more plugins that want to
> participate in bootstrapping we might want to make this explicit somehow.

They can't. Not unless we first write a pre-bootloader bootloader that could
discover the plugins that want to run during the bootloading process. That's
just a little too meta for my taste. :-)

[pquitslund, 2015-09-28 21:15:03]

https://chromiumcodereview.appspot.com/1373953002/diff/1/lib/src/bootloader.dart
File lib/src/bootloader.dart (right):

https://chromiumcodereview.appspot.com/1373953002/diff/1/lib/src/bootloader.d...
lib/src/bootloader.dart:113: List<OptionsProcessor> optionsProcessors =
On 2015/09/28 18:29:20, Brian Wilkerson wrote:
> > Actually, that's exactly what our PluginConfigOptionsProcessor is. If we
> didn't
> > add options processors we wouldn't see the plugins configured in
> > `.analysis_options`.
> >
> > ...
> >
> > In this case PluginConfigOptionsProcessor should actually ONLY getting run
in
> the
> > bootstrapping and not in the bootstrapped isolate.  Something to think
> about...
> 
> So it's an explicitly installed "plugin" that can only be loaded during the
> bootloading process? Doesn't sound much like a plugin, but OK. (I'd probably
not
> treat it like a plugin just to avoid confusing myself.)

I agree.  Addressed here:

https://codereview.chromium.org/1373903004/
> 
> > Side note: if there end up being more plugins that want to
> > participate in bootstrapping we might want to make this explicit somehow.
> 
> They can't. Not unless we first write a pre-bootloader bootloader that could
> discover the plugins that want to run during the bootloading process. That's
> just a little too meta for my taste. :-)

Ha!  We're on the same page.  As much as I like to go meta, this is taking it a
little far. :)