Delay signaling Shader cache is available until loading is complete.

Delay signaling Shader cache is available until loading is complete.

If we send the available callback before we've finished loading
the current cached shaders off disk there is a potential race condition
where we do a cache clear while reading. This causes an issue with
the iterators and the cache does not get cleared.

This patch delays the signaling of the available cache until after
we have finished iterating over the cache and loading the old shaders.

BUG=176289
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193411

[dsinclair, 2013-04-05 18:26:26]

Al, PTAL.

[apatrick_chromium, 2013-04-08 18:03:05]

lgtm

https://codereview.chromium.org/13730005/diff/1/content/browser/gpu/shader_di...
File content/browser/gpu/shader_disk_cache.cc (right):

https://codereview.chromium.org/13730005/diff/1/content/browser/gpu/shader_di...
content/browser/gpu/shader_disk_cache.cc:590: /* The cache is considered
available after we have finished reading any
nit: use // style comment rather than /* */

[dsinclair, 2013-04-09 22:52:02]

https://codereview.chromium.org/13730005/diff/1/content/browser/gpu/shader_di...
File content/browser/gpu/shader_disk_cache.cc (right):

https://codereview.chromium.org/13730005/diff/1/content/browser/gpu/shader_di...
content/browser/gpu/shader_disk_cache.cc:590: /* The cache is considered
available after we have finished reading any
On 2013/04/08 18:03:05, apatrick_chromium wrote:
> nit: use // style comment rather than /* */

Done.

[commit-bot: I haz the power, 2013-04-10 01:04:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/13730005/5001

[commit-bot: I haz the power, 2013-04-10 03:55:21]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-04-10 14:14:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/13730005/5001

[commit-bot: I haz the power, 2013-04-10 17:39:13]

Change committed as 193411