Add support for Tegra V4L2 VDA

content/common/gpu/media/exynos_v4l2_video_device.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 #include <fcntl.h>
 #include <linux/videodev2.h>
 #include <poll.h>
 #include <sys/eventfd.h>
 #include <sys/ioctl.h>
 #include <sys/mman.h>
 
 #include "base/debug/trace_event.h"
 #include "base/posix/eintr_wrapper.h"
 #include "content/common/gpu/media/exynos_v4l2_video_device.h"
+#include "ui/gl/gl_bindings.h"
 
 namespace content {
 
 namespace {
 const char kDevice[] = "/dev/mfc-dec";
 }
 
 ExynosV4L2Device::ExynosV4L2Device()
     : device_fd_(-1), device_poll_interrupt_fd_(-1) {}
 
@@ skipping 82 matching lines @@
   if (device_fd_ == -1) {
     return false;
   }
 
   device_poll_interrupt_fd_ = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);
   if (device_poll_interrupt_fd_ == -1) {
     return false;
   }
   return true;
 }
+
+EGLImageKHR ExynosV4L2Device::CreateEGLImage(EGLDisplay egl_display,
+                                             EGLint attrib[],
+                                             unsigned int texture_id,
+                                             unsigned int buffer_index) {

[Ami GONE FROM CHROMIUM, 2014/02/07 09:09:30]

Please /* comment out */ unused params.

+  EGLImageKHR egl_image = eglCreateImageKHR(

[Pawel Osciak, 2014/02/10 06:36:17]

We need to make GL context current to be able to call this.
We should at least require this in the doc that it should be done before calling
this method.

[shivdasp, 2014/02/14 03:06:45]

make_context_current_ is already done before calling this function. That should
be sufficient I believe. Or it has to be done again here ?
Also relatedly , how do I get the egl_context in which the textures are created
?
I am using eglGetCurrentContext() in the TegraV4L2Device.

On 2014/02/10 06:36:17, Pawel Osciak wrote:

[Pawel Osciak, 2014/02/14 07:36:10]

Yes, I'm just saying this method should explicitly state so in its documentation
at least.
But it's not really relevant anymore, this method should be no longer needed.
The context in which textures are created is the one you get as an argument to
the device right now, you restored that argument recently.

+      egl_display, EGL_NO_CONTEXT, EGL_LINUX_DMA_BUF_EXT, NULL, attrib);
+  if (egl_image == EGL_NO_IMAGE_KHR) {
+    DLOG(ERROR) << "CreateEGLImage(): could not create EGLImageKHR";
+    return egl_image;
+  }
+  glBindTexture(GL_TEXTURE_EXTERNAL_OES, texture_id);
+  glEGLImageTargetTexture2DOES(GL_TEXTURE_EXTERNAL_OES, egl_image);
+  return egl_image;
+}
+
+unsigned int ExynosV4L2Device::GetTextureTarget() {
+  return GL_TEXTURE_EXTERNAL_OES;
+}
+
 }  //  namespace content