components/history/core/browser/history_service.h - Issue 1368293012: HistoryQuickProviderTest.DeleteMatch thread safety fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_service.h

Issue 1368293012: HistoryQuickProviderTest.DeleteMatch thread safety fix. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/history_quick_provider_unittest.cc ('k') | components/history/core/browser/history_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/history_service.h

diff --git a/components/history/core/browser/history_service.h b/components/history/core/browser/history_service.h

index 62267e1b138f8bc0a143cd12bd2ef32f4de211d7..c61e474ede918e20ac580c6f0f0052c7557c1287 100644

--- a/components/history/core/browser/history_service.h

+++ b/components/history/core/browser/history_service.h

@@ -503,6 +503,10 @@ class HistoryService : public syncer::SyncableService, public KeyedService {

// Runs |flushed| after bouncing off the history thread.

void FlushForTest(const base::Closure& flushed);

+ // Runs |task| on the history thread, and then |reply| on the sending thread.

+ bool PostTaskAndReplyForTest(const base::Closure& task,

sky 2015/09/30 23:52:10 THis is effectively duplicating what HistoryDBTask

Scott Hess - ex-Googler 2015/10/01 18:08:39 Didn't know about that one. Converted.

+ const base::Closure& reply);

// Designed for unit tests, this passes the given task on to the history

// backend to be called once the history backend has terminated. This allows

// callers to know when the history thread is complete and the database files