HistoryQuickProviderTest.DeleteMatch thread safety fix.

components/history/core/browser/history_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_SERVICE_H_
 #define COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_SERVICE_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 485 matching lines @@
   scoped_ptr<base::CallbackList<void(const std::set<GURL>&,
                                      const GURL&)>::Subscription>
   AddFaviconsChangedCallback(const OnFaviconsChangedCallback& callback)
       WARN_UNUSED_RESULT;
 
   // Testing -------------------------------------------------------------------
 
   // Runs |flushed| after bouncing off the history thread.
   void FlushForTest(const base::Closure& flushed);
 
+  // Runs |task| on the history thread, and then |reply| on the sending thread.
+  bool PostTaskAndReplyForTest(const base::Closure& task,

[sky, 2015/09/30 23:52:10]

THis is effectively duplicating what HistoryDBTask does. Can you use it instead?

[Scott Hess - ex-Googler, 2015/10/01 18:08:39]

Didn't know about that one.  Converted.

+                               const base::Closure& reply);
+
   // Designed for unit tests, this passes the given task on to the history
   // backend to be called once the history backend has terminated. This allows
   // callers to know when the history thread is complete and the database files
   // can be deleted and the next test run. Otherwise, the history thread may
   // still be running, causing problems in subsequent tests.
   //
   // There can be only one closing task, so this will override any previously
   // set task. We will take ownership of the pointer and delete it when done.
   // The task will be run on the calling thread (this function is threadsafe).
   void SetOnBackendDestroyTask(const base::Closure& task);
@@ skipping 343 matching lines @@
 
   // All vended weak pointers are invalidated in Cleanup().
   base::WeakPtrFactory<HistoryService> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(HistoryService);
 };
 
 }  // namespace history
 
 #endif  // COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_SERVICE_H_