Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 1368293012: HistoryQuickProviderTest.DeleteMatch thread safety fix. (Closed)

Created:
5 years, 2 months ago by shess1
Modified:
5 years, 2 months ago
CC:
chromium-reviews, James Su
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HistoryQuickProviderTest.DeleteMatch thread safety fix. history_backend is not supposed to be used except on the history thread. The existing code manages to run because all of the underlying sql::Connection statements were generated before test SetUp() completed, so the previous calls could read statements from the cache without modifying it. BUG=537681 Committed: https://crrev.com/f20e6bb6c89853231d3ad519456a1df000eaf3e4 Cr-Commit-Position: refs/heads/master@{#352073}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Convert to HistoryDBTask. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -2 lines) Patch
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 1 6 chunks +55 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
Scott Hess - ex-Googler
sky@ as OWNER endegy@ as author of the bits of this test which are problematic ...
5 years, 2 months ago (2015-09-30 22:34:58 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368293012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368293012/1
5 years, 2 months ago (2015-09-30 22:35:57 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 23:50:07 UTC) #6
sky
https://chromiumcodereview.appspot.com/1368293012/diff/1/components/history/core/browser/history_service.h File components/history/core/browser/history_service.h (right): https://chromiumcodereview.appspot.com/1368293012/diff/1/components/history/core/browser/history_service.h#newcode507 components/history/core/browser/history_service.h:507: bool PostTaskAndReplyForTest(const base::Closure& task, THis is effectively duplicating what ...
5 years, 2 months ago (2015-09-30 23:52:10 UTC) #7
shess1
Convert to HistoryDBTask.
5 years, 2 months ago (2015-10-01 18:07:11 UTC) #8
Scott Hess - ex-Googler
https://chromiumcodereview.appspot.com/1368293012/diff/1/components/history/core/browser/history_service.h File components/history/core/browser/history_service.h (right): https://chromiumcodereview.appspot.com/1368293012/diff/1/components/history/core/browser/history_service.h#newcode507 components/history/core/browser/history_service.h:507: bool PostTaskAndReplyForTest(const base::Closure& task, On 2015/09/30 23:52:10, sky wrote: ...
5 years, 2 months ago (2015-10-01 18:08:39 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368293012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368293012/20001
5 years, 2 months ago (2015-10-01 18:11:04 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-01 18:59:03 UTC) #13
engedy
LGTM, thanks for taking care of this!
5 years, 2 months ago (2015-10-01 22:15:41 UTC) #14
sky
LGTM
5 years, 2 months ago (2015-10-02 15:34:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368293012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368293012/20001
5 years, 2 months ago (2015-10-02 17:44:02 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-02 17:55:06 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 17:56:51 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f20e6bb6c89853231d3ad519456a1df000eaf3e4
Cr-Commit-Position: refs/heads/master@{#352073}

Powered by Google App Engine
This is Rietveld 408576698