Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13679005: Remove MSID and bundle from the answer as well as offer in WebRtc content_browsertest. (Closed)

Created:
7 years, 8 months ago by perkj_chrome
Modified:
7 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Remove MSID and bundle from the answer as well as offer in WebRtc content_browsertest. BUG=175683, 177443 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192567

Patch Set 1 : #

Patch Set 2 : Reenabled the test CallWithDataAndLaterAddMedia. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
perkj_chrome
The issues are in the test code luckily. Can you please review?
7 years, 8 months ago (2013-04-05 08:50:17 UTC) #1
phoglund_chromium
lgtm. Does this mean you can un-disable the CallWithDataAndLaterAddMedia test?
7 years, 8 months ago (2013-04-05 11:56:27 UTC) #2
perkj_chrome
On 2013/04/05 11:56:27, phoglund wrote: > lgtm. Does this mean you can un-disable the CallWithDataAndLaterAddMedia ...
7 years, 8 months ago (2013-04-05 13:00:54 UTC) #3
perkj_chrome
xians- can I get your help as an owner in this folder.
7 years, 8 months ago (2013-04-05 13:03:13 UTC) #4
no longer working on chromium
On 2013/04/05 13:03:13, perkj wrote: > xians- can I get your help as an owner ...
7 years, 8 months ago (2013-04-05 13:06:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/13679005/5001
7 years, 8 months ago (2013-04-05 13:07:03 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 15:31:11 UTC) #7
Message was sent while issue was closed. 
Change committed as 192567

Powered by Google App Engine
This is Rietveld 408576698