Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: content/test/data/media/peerconnection-call.html

Issue 13679005: Remove MSID and bundle from the answer as well as offer in WebRtc content_browsertest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reenabled the test CallWithDataAndLaterAddMedia. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/media/webrtc_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/data/media/peerconnection-call.html
diff --git a/content/test/data/media/peerconnection-call.html b/content/test/data/media/peerconnection-call.html
index 4a85e9cb2844f2ed2eaca455ce2e2b14c52fc8d6..7581b729947e8f3370b4d4aa4652e232c6090185 100644
--- a/content/test/data/media/peerconnection-call.html
+++ b/content/test/data/media/peerconnection-call.html
@@ -49,9 +49,8 @@
createConnections(null);
gTestWithoutMsidAndBundle = true;
navigator.webkitGetUserMedia({audio:true, video:true},
- addStreamToBothConnectionsAndNegotiate, printGetUserMediaError);
- // TODO(phoglund): this should work but it doesn't! http://crbug.com/177443.
- // waitForVideo('remote-view-1');
+ addStreamToBothConnectionsAndNegotiate, printGetUserMediaError);
+ waitForVideo('remote-view-1');
waitForVideo('remote-view-2');
}
@@ -75,10 +74,6 @@
// Test call with a data channel and later add audio and video.
function callWithDataAndLaterAddMedia() {
- // TODO(perkj): This is needed for now until
- // https://code.google.com/p/webrtc/issues/detail?id=1203 is fixed.
- gTestWithoutMsidAndBundle = true;
-
createConnections({optional:[{RtpDataChannels: true}]});
setupDataChannel();
gFirstConnection.createOffer(onOfferCreated);
@@ -243,10 +238,13 @@
function onAnswerCreated(answer) {
gSecondConnection.setLocalDescription(answer);
expectEquals('stable', gSecondConnection.signalingState);
- handleAnswer(answer.sdp);
+ receiveAnswer(answer.sdp);
}
- function handleAnswer(answerSdp) {
+ function receiveAnswer(answerSdp) {
+ if (gTestWithoutMsidAndBundle) {
+ answerSdp = removeMsidAndBundle(answerSdp);
+ }
var parsedAnswer = new RTCSessionDescription({ type: 'answer',
sdp: answerSdp });
gFirstConnection.setRemoteDescription(parsedAnswer);
« no previous file with comments | « content/browser/media/webrtc_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698