third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp - Issue 1366203002: Add dump name for tracing in PartitionAlloc for sub-allocations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

Issue 1366203002: Add dump name for tracing in PartitionAlloc for sub-allocations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web_cache

Patch Set: Just adding pool name. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

diff --git a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

index 3f5dd7c48d0177125c6eb69e26ee4419b34ee1dc..2a1bb6381f54f6c960c5d1aad81788f5d5705255 100644

--- a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

+++ b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

@@ -100,8 +100,7 @@ bool PartitionAllocMemoryDumpProvider::onMemoryDump(WebMemoryDumpLevelOfDetail l

// This method calls memoryStats.partitionsDumpBucketStats with memory statistics.

WTF::Partitions::dumpMemoryStats(levelOfDetail == WebMemoryDumpLevelOfDetail::Light, &partitionStatsDumper);

- WebMemoryAllocatorDump* allocatedObjectsDump = memoryDump->createMemoryAllocatorDump(

- String::format("%s/allocated_objects", kPartitionAllocDumpName));

+ WebMemoryAllocatorDump* allocatedObjectsDump = memoryDump->createMemoryAllocatorDump(String(Partitions::kAllocatedObjectPoolName));

allocatedObjectsDump->AddScalar("size", "bytes", partitionStatsDumper.totalActiveBytes());

memoryDump->AddOwnershipEdge(allocatedObjectsDump->guid(), partitionsDump->guid());

« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/Partitions.h » ('j') | no next file with comments »