Add dump name for tracing in PartitionAlloc for sub-allocations

third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "platform/PartitionAllocMemoryDumpProvider.h"
 
 #include "public/platform/WebMemoryAllocatorDump.h"
 #include "public/platform/WebProcessMemoryDump.h"
 #include "wtf/Partitions.h"
 
 namespace blink {
 
 namespace {
 
 using namespace WTF;
 
 const char kPartitionAllocDumpName[] = "partition_alloc";
 const char kPartitionsDumpName[] = "partitions";

[haraken, 2015/09/30 23:56:53]

Maybe do you want to move this to Partitions.h in a follow-up CL?

[ssid, 2015/10/01 10:24:41]

Hm, actually these strings are not required to be partitinos.h. and more strings
like this can add up if we add more details in the dump. It is not very clean to
keep adding strings in Partitions.h which is only used in this file. So, only
moving one string there.

 
 String getPartitionDumpName(const char* partitionName)
 {
     return String::format("%s/%s/%s", kPartitionAllocDumpName, kPartitionsDumpName, partitionName);
 }
 
 // This class is used to invert the dependency of PartitionAlloc on the
 // PartitionAllocMemoryDumpProvider. This implements an interface that will
 // be called with memory statistics for each bucket in the allocator.
 class PartitionStatsDumperImpl final : public PartitionStatsDumper {
@@ skipping 63 matching lines @@
 bool PartitionAllocMemoryDumpProvider::onMemoryDump(WebMemoryDumpLevelOfDetail levelOfDetail, WebProcessMemoryDump* memoryDump)
 {
     PartitionStatsDumperImpl partitionStatsDumper(memoryDump, levelOfDetail);
 
     WebMemoryAllocatorDump* partitionsDump = memoryDump->createMemoryAllocatorDump(
         String::format("%s/%s", kPartitionAllocDumpName, kPartitionsDumpName));
 
     // This method calls memoryStats.partitionsDumpBucketStats with memory statistics.
     WTF::Partitions::dumpMemoryStats(levelOfDetail == WebMemoryDumpLevelOfDetail::Light, &partitionStatsDumper);
 
-    WebMemoryAllocatorDump* allocatedObjectsDump = memoryDump->createMemoryAllocatorDump(
-        String::format("%s/allocated_objects", kPartitionAllocDumpName));
+    WebMemoryAllocatorDump* allocatedObjectsDump = memoryDump->createMemoryAllocatorDump(String(Partitions::kAllocatedObjectPoolName));
     allocatedObjectsDump->AddScalar("size", "bytes", partitionStatsDumper.totalActiveBytes());
     memoryDump->AddOwnershipEdge(allocatedObjectsDump->guid(), partitionsDump->guid());
 
     return true;
 }
 
 PartitionAllocMemoryDumpProvider::PartitionAllocMemoryDumpProvider()
 {
 }
 
 PartitionAllocMemoryDumpProvider::~PartitionAllocMemoryDumpProvider()
 {
 }
 
 } // namespace blink