Add dump name for tracing in PartitionAlloc for sub-allocations

Add dump name for tracing in PartitionAlloc for sub-allocations

The objects allocated from partition alloc will be dumped in traces in
future. For this The dumps will be required to add sub-allocations from
partitionAlloc, which go under "partition_alloc/allocated_objects/".
This CL adds a getter for the name so that clients of PartitionAlloc
can add sub-allocations.

BUG=520842
Committed: https://crrev.com/614d2d91d19db4f753202479d64f920d29dd1dc2
Cr-Commit-Position: refs/heads/master@{#351769}

[ssid, 2015-09-25 15:12:14]

ssid@chromium.org changed reviewers:
+ primiano@chromium.org

[ssid, 2015-09-25 15:12:15]

PTAL, thanks

[ssid, 2015-09-29 16:14:23]

ssid@chromium.org changed reviewers:
+ haraken@chromium.org

[ssid, 2015-09-29 16:14:23]

+haraken
As you would have seen in the dependent CL, this change is to add
sub-allocations from PartitionAlloc.

This change adds the name in Partitions file because any client using
PartitionAlloc should be able to get the name for sub-allocation.

This was the pattern in chrome (like
MemoryDumpManager::system_allocator_pool_name()).

[haraken, 2015-09-29 16:20:17]

https://codereview.chromium.org/1366203002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp
(right):

https://codereview.chromium.org/1366203002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp:20:
const char kPartitionsDumpName[] = "partitions";

How about just defining these constant strings in Partitions.h instead of
setting them dynamically?

[Primiano Tucci (use gerrit), 2015-09-29 16:52:30]

Had a chat offline with ssid. Before making further changes to Palloc dump
provider let's make sure that the math that subtracts the owned allocations from
other dumpers is right.

[Primiano Tucci (use gerrit), 2015-09-30 15:56:36]

On 2015/09/29 16:52:30, Primiano Tucci wrote:
> Had a chat offline with ssid. Before making further changes to Palloc dump
> provider let's make sure that the math that subtracts the owned allocations
from
> other dumpers is right.

LGTM, but I'd leave only one string (the one you need) in Partitions.h

[ssid, 2015-09-30 18:06:57]

Fixed the issues. Now I made the CL very small, just adds a Name in
Partitions.h. PTAL, thanks

[ssid, 2015-09-30 20:01:54]

Patchset #3 (id:40001) has been deleted

[haraken, 2015-09-30 23:56:53]

LGTM

https://chromiumcodereview.appspot.com/1366203002/diff/60001/third_party/WebK...
File third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp
(right):

https://chromiumcodereview.appspot.com/1366203002/diff/60001/third_party/WebK...
third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp:19:
const char kPartitionsDumpName[] = "partitions";

Maybe do you want to move this to Partitions.h in a follow-up CL?

[ssid, 2015-10-01 10:24:41]

https://chromiumcodereview.appspot.com/1366203002/diff/60001/third_party/WebK...
File third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp
(right):

https://chromiumcodereview.appspot.com/1366203002/diff/60001/third_party/WebK...
third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp:19:
const char kPartitionsDumpName[] = "partitions";
On 2015/09/30 23:56:53, haraken wrote:
> 
> Maybe do you want to move this to Partitions.h in a follow-up CL?

Hm, actually these strings are not required to be partitinos.h. and more strings
like this can add up if we add more details in the dump. It is not very clean to
keep adding strings in Partitions.h which is only used in this file. So, only
moving one string there.

[ssid, 2015-10-01 10:24:45]

The CQ bit was checked by ssid@chromium.org

[ssid, 2015-10-01 10:24:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1366203002/#ps60001
(title: "Just adding pool name.")

[commit-bot: I haz the power, 2015-10-01 10:25:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1366203002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1366203002/60001

[commit-bot: I haz the power, 2015-10-01 10:30:07]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-10-01 10:30:57]

Patchset 3 (id:??) landed as
https://crrev.com/614d2d91d19db4f753202479d64f920d29dd1dc2
Cr-Commit-Position: refs/heads/master@{#351769}