Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 13652007: workaround various mixin bugs (Closed)

Created:
7 years, 8 months ago by Jennifer Messerly
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org, sethladd
Base URL:
https://github.com/dart-lang/web-ui.git@master
Visibility:
Public.

Description

workaround various mixin bugs * dart2js doesn't like private fields * vm gets confused by type annotation Committed: https://github.com/dart-lang/web-ui/commit/52237ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -28 lines) Patch
M lib/observe/observable.dart View 6 chunks +18 lines, -16 lines 0 comments Download
A + test/data/expected/checked_mode_test.html.txt View 1 chunk +2 lines, -4 lines 0 comments Download
A + test/data/input/checked_mode_test.html View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
7 years, 8 months ago (2013-04-04 20:35:51 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years, 8 months ago (2013-04-04 21:02:40 UTC) #2
Jennifer Messerly
7 years, 8 months ago (2013-04-04 21:18:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r52237ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698