Delete layout_viewport_size.

Delete layout_viewport_size.

This value is redundant.  We can use the root cliprect size or the
device_viewport_size divided by device_scale_factor instead.

This value was only used by PinchZoomScrollbars, I replaced it
with one that should be equivalent.

NOTRY=true
BUG=229098
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193013

[aelias_OOO_until_Jul13, 2013-04-08 22:16:29]

PTAL.

This leaves some WebKit API dregs but otherwise deletes the value entirely.

[wjmaclean, 2013-04-08 22:35:28]

On 2013/04/08 22:16:29, aelias wrote:
> PTAL.
> 
> This leaves some WebKit API dregs but otherwise deletes the value entirely.

It's worth noting the root clip rect is not equivalent when non-overlay
scrollbars are used, as the clip rect is the viewport size less the scrollbar
sizes. But, as long as everyone's OK with dividing the device viewport by the
device scale factor then that should be OK (though is it always guaranteed to
give an integer size for unusual scale factors?).

[aelias_OOO_until_Jul13, 2013-04-08 22:53:59]

It's not guaranteed to be an integer, but if you ceil it, this will give the
same value that was provided to WebKit and given to CC as layout_viewport_size.

[aelias_OOO_until_Jul13, 2013-04-08 23:13:51]

Adding jamesr@ and piman@ for OWNERS.

[danakj, 2013-04-09 00:04:35]

LGTM if wjmaclean is okay with the pinch zoom scrollbar changes.

https://codereview.chromium.org/13637017/diff/6001/cc/input/pinch_zoom_scroll...
File cc/input/pinch_zoom_scrollbar.cc (right):

https://codereview.chromium.org/13637017/diff/6001/cc/input/pinch_zoom_scroll...
cc/input/pinch_zoom_scrollbar.cc:43: gfx::Size viewport_size =
gfx::ToCeiledSize(gfx::ScaleSize(
Is there a nice way to not duplicate this logic with LTH?

https://codereview.chromium.org/13637017/diff/6001/cc/trees/layer_tree_host.cc
File cc/trees/layer_tree_host.cc (right):

https://codereview.chromium.org/13637017/diff/6001/cc/trees/layer_tree_host.c...
cc/trees/layer_tree_host.cc:389: gfx::ScaleSize(device_viewport_size(), 1 /
device_scale_factor()));
nit: 1.f

https://codereview.chromium.org/13637017/diff/6001/content/renderer/gpu/rende...
File content/renderer/gpu/render_widget_compositor.h (right):

https://codereview.chromium.org/13637017/diff/6001/content/renderer/gpu/rende...
content/renderer/gpu/render_widget_compositor.h:48: const WebKit::WebSize&,
nit: should keep the variable name here and in the .cc

https://codereview.chromium.org/13637017/diff/6001/webkit/compositor_bindings...
File webkit/compositor_bindings/web_layer_tree_view_impl_for_testing.h (right):

https://codereview.chromium.org/13637017/diff/6001/webkit/compositor_bindings...
webkit/compositor_bindings/web_layer_tree_view_impl_for_testing.h:38: virtual
void setViewportSize(const WebKit::WebSize&,
nit: and keep the variable name here, it's chromium style to always have a name.

[jamesr, 2013-04-09 00:11:51]

webkit/ lgtm

https://codereview.chromium.org/13637017/diff/6001/webkit/compositor_bindings...
File webkit/compositor_bindings/web_layer_tree_view_impl_for_testing.cc (right):

https://codereview.chromium.org/13637017/diff/6001/webkit/compositor_bindings...
webkit/compositor_bindings/web_layer_tree_view_impl_for_testing.cc:79: const
WebSize&,
chromium style is to keep the variable name here, even if it's unused

[piman, 2013-04-09 00:20:45]

https://codereview.chromium.org/13637017/diff/6001/content/renderer/gpu/rende...
File content/renderer/gpu/render_widget_compositor.h (right):

https://codereview.chromium.org/13637017/diff/6001/content/renderer/gpu/rende...
content/renderer/gpu/render_widget_compositor.h:48: const WebKit::WebSize&,
nit: in chromium code we don't generally omit parameter names

[aelias_OOO_until_Jul13, 2013-04-09 00:26:10]

Antoine: did you forget to lgt m?

[piman, 2013-04-09 00:39:28]

On 2013/04/09 00:26:10, aelias wrote:
> Antoine: did you forget to lgt m?

Ah, sorry, LGTM.

[aelias_OOO_until_Jul13, 2013-04-09 01:18:55]

OK, I merged all duplicative code into a new method
LayerTreeHost::PinchZoomScrollbarSize and named the unused argument
"unused_deprecated".

[commit-bot: I haz the power, 2013-04-09 04:58:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aelias@chromium.org/13637017/21001

[commit-bot: I haz the power, 2013-04-09 04:58:41]

Change committed as 193013