Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.h

Issue 1363023005: Implement FullScreen using top layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Fullscreen.h
diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.h b/third_party/WebKit/Source/core/dom/Fullscreen.h
index 8e8a8639599dcab5fb172f6a40c6c99a23332d2b..d5014ed3abe94ef83191df1093da54ad457db527 100644
--- a/third_party/WebKit/Source/core/dom/Fullscreen.h
+++ b/third_party/WebKit/Source/core/dom/Fullscreen.h
@@ -41,7 +41,6 @@
namespace blink {
-class LayoutFullScreen;
class ComputedStyle;
class CORE_EXPORT Fullscreen final
@@ -78,9 +77,7 @@ public:
void didEnterFullScreenForElement(Element*);
void didExitFullScreenForElement(Element*);
- void setFullScreenLayoutObject(LayoutFullScreen*);
- LayoutFullScreen* fullScreenLayoutObject() const { return m_fullScreenLayoutObject; }
- void fullScreenLayoutObjectDestroyed();
+ void updatedSize(Element*);
philipj_slow 2015/09/29 08:05:23 Make it Element& since it cannot be null? (didExit
Julien - ping for review 2015/10/01 00:24:40 Also usual Blink style would name this function di
dsinclair 2015/10/01 14:50:13 Done.
dsinclair 2015/10/01 14:50:13 Done.
void elementRemoved(Element&);
@@ -94,6 +91,8 @@ public:
DECLARE_VIRTUAL_TRACE();
+ const WillBeHeapVector<std::pair<RefPtrWillBeMember<Element>, RequestType>>& fullScreenElementStack() const { return m_fullScreenElementStack; }
+
private:
static Fullscreen* fromIfExistsSlow(Document&);
@@ -111,7 +110,6 @@ private:
RefPtrWillBeMember<Element> m_fullScreenElement;
WillBeHeapVector<std::pair<RefPtrWillBeMember<Element>, RequestType>> m_fullScreenElementStack;
- LayoutFullScreen* m_fullScreenLayoutObject;
Timer<Fullscreen> m_eventQueueTimer;
WillBeHeapDeque<RefPtrWillBeMember<Event>> m_eventQueue;
LayoutRect m_savedPlaceholderFrameRect;

Powered by Google App Engine
This is Rietveld 408576698