third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp - Issue 1363023005: Implement FullScreen using top layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 1363023005: Implement FullScreen using top layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

index cde74055127060bfdae14c9d5a8a6a459bdfa1dc..dc73db009c870c5097514d0baa4087c2f9280021 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

@@ -254,7 +254,6 @@ void HTMLPlugInElement::detach(const AttachContext& context)

m_isDelayingLoadEvent = false;

document().decrementLoadEventDelayCount();

}

Julien - ping for review 2015/10/01 00:24:40 Empty line removal? Unneeded churn?

dsinclair 2015/10/01 14:50:14 Leftover from debugging. Fixed.

// Only try to persist a plugin widget we actually own.

Widget* plugin = ownedWidget();

if (plugin && context.performingReattach)