bindings: Moves event handlers and methods of Window to the instance object.

bindings: Moves event handlers and methods of Window to the instance object.

Makes v8_utilities.on_{instance,prototype,interface} conformant to the spec.

Moves event handlers and methods on Window from the prototype object to
the instance object.  Also moves members of [Global] interfaces to the
instance objects.

BUG=43394, 516274
Committed: https://crrev.com/eb2728fc03dead670668dbeb071e8584e2a0504b
Cr-Commit-Position: refs/heads/master@{#350827}

[Yuki, 2015-09-25 06:39:06]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuki, 2015-09-25 06:39:07]

Could you review this CL?

[haraken, 2015-09-25 10:41:35]

Great work! LGTM to try.

https://codereview.chromium.org/1360233007/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/1360233007/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/interface.cpp:638: ' |
'.join(method.property_attributes or ['v8::None']) %}

Just help me understand: Why do we need to make this change?

[Yuki, 2015-09-25 14:40:43]

https://codereview.chromium.org/1360233007/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/1360233007/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/interface.cpp:638: ' |
'.join(method.property_attributes or ['v8::None']) %}
On 2015/09/25 10:41:35, haraken wrote:
> 
> Just help me understand: Why do we need to make this change?

Unless it's [Unforgeable], JS properties corresponding to attributes or
operations should be {configuable: true}.  This is true even for whitelisted
members of Window.

Especially when we're moving them to the instance object, if it's
v8::DontDelete, the following code doesn't work.
    // in the global scope
    function toString() { ... }
because we already have toString() method on the instance object of Window.

[Yuki, 2015-09-25 14:41:46]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2015-09-25 14:42:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360233007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360233007/1

[haraken, 2015-09-25 14:43:11]

On 2015/09/25 14:40:43, Yuki wrote:
>
https://codereview.chromium.org/1360233007/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/bindings/templates/interface.cpp (right):
> 
>
https://codereview.chromium.org/1360233007/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/bindings/templates/interface.cpp:638: ' |
> '.join(method.property_attributes or ['v8::None']) %}
> On 2015/09/25 10:41:35, haraken wrote:
> > 
> > Just help me understand: Why do we need to make this change?
> 
> Unless it's [Unforgeable], JS properties corresponding to attributes or
> operations should be {configuable: true}.  This is true even for whitelisted
> members of Window.
> 
> Especially when we're moving them to the instance object, if it's
> v8::DontDelete, the following code doesn't work.
>     // in the global scope
>     function toString() { ... }
> because we already have toString() method on the instance object of Window.

Thanks, makes sense :)

[commit-bot: I haz the power, 2015-09-25 15:08:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-25 15:09:57]

Patchset 1 (id:??) landed as
https://crrev.com/eb2728fc03dead670668dbeb071e8584e2a0504b
Cr-Commit-Position: refs/heads/master@{#350827}