Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_methods.py

Issue 1360233007: bindings: Moves event handlers and methods of Window to the instance object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_methods.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_methods.py b/third_party/WebKit/Source/bindings/scripts/v8_methods.py
index 7b7c0cc25848acbd0568344f430a70b3d3970c10..47a0e052d915a9a5f5976162167372f95dd4bef9 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_methods.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_methods.py
@@ -218,8 +218,8 @@ def argument_context(interface, method, argument, index, is_visible=True):
idl_type.is_wrapper_type)
if ('ImplementedInPrivateScript' in extended_attributes and
- not idl_type.is_wrapper_type and
- not idl_type.is_basic_type):
+ not idl_type.is_wrapper_type and
+ not idl_type.is_basic_type):
raise Exception('Private scripts supports only primitive types and DOM wrappers.')
set_default_value = argument.set_default_value
@@ -307,8 +307,8 @@ def cpp_value(interface, method, number_of_arguments):
# static member functions, which for instance members (non-static members)
# take *impl as their first argument
if ('PartialInterfaceImplementedAs' in method.extended_attributes and
- not 'ImplementedInPrivateScript' in method.extended_attributes and
- not method.is_static):
+ 'ImplementedInPrivateScript' not in method.extended_attributes and
+ not method.is_static):
cpp_arguments.append('*impl')
cpp_arguments.extend(cpp_argument(argument) for argument in arguments)
@@ -316,8 +316,8 @@ def cpp_value(interface, method, number_of_arguments):
if method.idl_type.name != 'void':
cpp_arguments.append('&result')
elif ('RaisesException' in method.extended_attributes or
- (method.is_constructor and
- has_extended_attribute_value(interface, 'RaisesException', 'Constructor'))):
+ (method.is_constructor and
+ has_extended_attribute_value(interface, 'RaisesException', 'Constructor'))):
cpp_arguments.append('exceptionState')
# If a method returns an IDL dictionary or union type, the return value is
@@ -347,8 +347,8 @@ def v8_set_return_value(interface_name, method, cpp_value, for_main_world=False)
return None
if ('ImplementedInPrivateScript' in extended_attributes and
- not idl_type.is_wrapper_type and
- not idl_type.is_basic_type):
+ not idl_type.is_wrapper_type and
+ not idl_type.is_basic_type):
raise Exception('Private scripts supports only primitive types and DOM wrappers.')
release = False
@@ -405,7 +405,7 @@ def v8_value_to_local_cpp_value(method, argument, index, return_promise=False, r
# Auxiliary functions
################################################################################
-# [NotEnumerable]
+# [NotEnumerable], [Unforgeable]
def property_attributes(interface, method):
extended_attributes = method.extended_attributes
property_attributes_list = []
@@ -413,8 +413,7 @@ def property_attributes(interface, method):
property_attributes_list.append('v8::DontEnum')
if is_unforgeable(interface, method):
property_attributes_list.append('v8::ReadOnly')
- if property_attributes_list:
- property_attributes_list.insert(0, 'v8::DontDelete')
+ property_attributes_list.append('v8::DontDelete')
return property_attributes_list

Powered by Google App Engine
This is Rietveld 408576698