Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 13602003: Add new methods to DriveServiceInterface. These will replace GetResourceList. (Closed)

Created:
7 years, 8 months ago by hidehiko
Modified:
7 years, 8 months ago
Reviewers:
hashimoto, kinaba
CC:
chromium-reviews, tfarina, achuith+watch_chromium.org, tzik, Haruki Sato
Base URL:
http://git.chromium.org/chromium/src.git@webkit_master
Visibility:
Public.

Description

Add new methods to DriveServiceInterface. These will replace GetResourceList. This is the preparation to split the method GetResourceList, which has now become complicated, and difficult to support all the functions on Drive API v2. The main goal is, by splitting GetResourceList based on the requirement and actual usage, supporting them on Drive API v2. This is the first step of the work. BUG=160932 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -1 line) Patch
M chrome/browser/google_apis/drive_api_service.h View 1 chunk +18 lines, -1 line 0 comments Download
M chrome/browser/google_apis/drive_api_service.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_service_interface.h View 2 chunks +72 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/dummy_drive_service.h View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/dummy_drive_service.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/fake_drive_service.h View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/fake_drive_service.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.h View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/mock_drive_service.h View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hidehiko
This CL just introduces new methods, and does no other things. CC'ed: haruki, tzik. Just ...
7 years, 8 months ago (2013-04-04 05:59:10 UTC) #1
hashimoto
lgtm
7 years, 8 months ago (2013-04-04 06:02:29 UTC) #2
kinaba
lgtm
7 years, 8 months ago (2013-04-04 06:02:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13602003/1
7 years, 8 months ago (2013-04-04 08:06:57 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-04 11:06:30 UTC) #5
Message was sent while issue was closed.
Change committed as 192289

Powered by Google App Engine
This is Rietveld 408576698