Fix use-after-free of Profile after it's been destroyed.

Fix use-after-free of Profile after it's been destroyed.

Make AccessibilityEventRouterViews listen for NOTIFICATION_PROFILE_DESTROYED
so that it can clear its most_recent_profile_ variable. Also fix call to
g_browser_process->profile_manager()->GetLastUsedProfile() because I
observed that profile_manager can sometimes be NULL during startup.
Warn if no valid profile is found, but this is non-fatal as long as it's
just a transient condition during startup/shutdown.

BUG=223276
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192302

[dmazzoni, 2013-04-03 21:16:43]

Thanks again, this turned out to be a real bug.

[Lei Zhang, 2013-04-03 21:56:49]

lgtm with some nits.

https://codereview.chromium.org/13584005/diff/1/chrome/browser/ui/views/acces...
File chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc
(right):

https://codereview.chromium.org/13584005/diff/1/chrome/browser/ui/views/acces...
chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc:114:
if (type == chrome::NOTIFICATION_PROFILE_DESTROYED) {
You can just DCHECK this.

https://codereview.chromium.org/13584005/diff/1/chrome/browser/ui/views/acces...
File chrome/browser/ui/views/accessibility/accessibility_event_router_views.h
(right):

https://codereview.chromium.org/13584005/diff/1/chrome/browser/ui/views/acces...
chrome/browser/ui/views/accessibility/accessibility_event_router_views.h:169:
scoped_ptr<content::NotificationRegistrar> registrar_;
Any particular reason for making it a scoper? Most code I have read just
declares it as: <content::NotificationRegistrar registrar_;

[dmazzoni, 2013-04-03 22:02:29]

https://codereview.chromium.org/13584005/diff/1/chrome/browser/ui/views/acces...
File chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc
(right):

https://codereview.chromium.org/13584005/diff/1/chrome/browser/ui/views/acces...
chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc:114:
if (type == chrome::NOTIFICATION_PROFILE_DESTROYED) {
On 2013/04/03 21:56:49, Lei Zhang wrote:
> You can just DCHECK this.

Done.

https://codereview.chromium.org/13584005/diff/1/chrome/browser/ui/views/acces...
File chrome/browser/ui/views/accessibility/accessibility_event_router_views.h
(right):

https://codereview.chromium.org/13584005/diff/1/chrome/browser/ui/views/acces...
chrome/browser/ui/views/accessibility/accessibility_event_router_views.h:169:
scoped_ptr<content::NotificationRegistrar> registrar_;
On 2013/04/03 21:56:49, Lei Zhang wrote:
> Any particular reason for making it a scoper? Most code I have read just
> declares it as: <content::NotificationRegistrar registrar_;

One less include in a header file?

I have no strong preference, I got rid of the scoped_ptr.

[commit-bot: I haz the power, 2013-04-03 22:02:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/13584005/2004

[Lei Zhang, 2013-04-03 22:08:38]

lgtm++

[commit-bot: I haz the power, 2013-04-03 22:46:09]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-03 22:53:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/13584005/2004

[commit-bot: I haz the power, 2013-04-04 11:39:21]

Change committed as 192302