Issue 13583005: Work around bug coming back from hiding menu bar with fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13583005: Work around bug coming back from hiding menu bar with fullscreen. (Closed)

Created:
7 years, 8 months ago by Avi (use Gerrit)

Modified:
7 years, 8 months ago

Reviewers:
Nico

CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Work around bug coming back from hiding menu bar with fullscreen. BUG=170189, 225659 TEST=as in bug 225659 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192301

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
	M	base/mac/mac_util.mm	View		2 chunks	+21 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://codereview.chromium.org/13583005/diff/1/base/mac/mac_util.mm File base/mac/mac_util.mm (right): https://codereview.chromium.org/13583005/diff/1/base/mac/mac_util.mm#newcode76 base/mac/mac_util.mm:76: // options to the ones that are set ...

7 years, 8 months ago (2013-04-03 22:16:07 UTC) #2

Avi (use Gerrit)

On 2013/04/03 22:16:07, Nico wrote: > file rdar Will do.

7 years, 8 months ago (2013-04-03 22:38:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/13583005/1

7 years, 8 months ago (2013-04-03 22:39:48 UTC) #4

Message was sent while issue was closed.

Change committed as 192301

Expand Messages | Collapse Messages