Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 13583005: Work around bug coming back from hiding menu bar with fullscreen. (Closed)

Created:
7 years, 8 months ago by Avi (use Gerrit)
Modified:
7 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Work around bug coming back from hiding menu bar with fullscreen. BUG=170189, 225659 TEST=as in bug 225659 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192301

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M base/mac/mac_util.mm View 2 chunks +21 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
7 years, 8 months ago (2013-04-03 21:24:03 UTC) #1
Nico
lgtm https://codereview.chromium.org/13583005/diff/1/base/mac/mac_util.mm File base/mac/mac_util.mm (right): https://codereview.chromium.org/13583005/diff/1/base/mac/mac_util.mm#newcode76 base/mac/mac_util.mm:76: // options to the ones that are set ...
7 years, 8 months ago (2013-04-03 22:16:07 UTC) #2
Avi (use Gerrit)
On 2013/04/03 22:16:07, Nico wrote: > file rdar Will do.
7 years, 8 months ago (2013-04-03 22:38:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/13583005/1
7 years, 8 months ago (2013-04-03 22:39:48 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-04 11:39:03 UTC) #5
Message was sent while issue was closed.
Change committed as 192301

Powered by Google App Engine
This is Rietveld 408576698