Issue 13560013: Fix errors in async_push.py and test code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13560013: Fix errors in async_push.py and test code. (Closed)

Created:
7 years, 8 months ago by M-A Ruel

Modified:
7 years, 8 months ago

Reviewers:
csharp

CC:
chromium-reviews, cmp-cc_chromium.org

Base URL:
https://git.chromium.org/chromium/tools/commit-queue.git@master

Visibility:
Public.

Fix errors in async_push.py and test code. The test code wasn't mocking properly, causing DNS lookup that can be observed when running the test without network access, like when at 40kft in the air. R=csharp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=192846

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	async_push.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/project_test.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/13560013/1

7 years, 8 months ago (2013-04-08 18:35:44 UTC) #3

Message was sent while issue was closed.

Change committed as 192846