Managed user creation flow:

Managed user creation flow:
   Add network error handling.
   Cancelling flow will not perform restart if manager is not signed in yet.
   Fix buttons in header bar.
   Do not hide tray.

BUG=176277, 226101
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192311

[Denis Kuznetsov (DE-MUC), 2013-04-03 16:59:22]

Yuri for reviewing main part (error screen).
Nikita for reviewing fixes of glitches.

[Nikita (slow), 2013-04-03 17:25:41]

lgtm

https://codereview.chromium.org/13553002/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/error_screen.h (right):

https://codereview.chromium.org/13553002/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/error_screen.h:26: UI_STATE_MANAGED
nit: UI_STATE_LOCALLY_MANAGED

https://codereview.chromium.org/13553002/diff/1/chrome/browser/chromeos/login...
File
chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc
(right):

https://codereview.chromium.org/13553002/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc:16:

nit: drop empty line

https://codereview.chromium.org/13553002/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc:58:
// hide error screen
nit: drop comment

https://codereview.chromium.org/13553002/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc:61:
// show error screen
nit: drop comment

https://codereview.chromium.org/13553002/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc:69:

nit: drop empty line

https://codereview.chromium.org/13553002/diff/1/chrome/browser/chromeos/login...
File
chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.h
(right):

https://codereview.chromium.org/13553002/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.h:77:

nit: drop empty line

https://codereview.chromium.org/13553002/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/display_manager.js (right):

https://codereview.chromium.org/13553002/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/display_manager.js:48:
MANAGED_USER_CREATION_FLOW: 'ui-state-managed'
nit: ui-state-locally-managed

[ygorshenin1, 2013-04-03 17:33:32]

https://chromiumcodereview.appspot.com/13553002/diff/1/chrome/browser/chromeo...
File
chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc
(right):

https://chromiumcodereview.appspot.com/13553002/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc:65:
get_screen_observer()->ShowErrorScreen();
What is the error state for the error screen?

[Denis Kuznetsov (DE-MUC), 2013-04-03 19:56:17]

Fixed Nikita's nits, changed implementation to NetworkPortalDetector.

Question for Yuri : If we are already behind captive portal and I call
NetworkPortalDetector::ForcePortalDetection, will I get notification in Observer
(on the one hand, state have not changed, on the other, I forced re-detection). 
If answer to previous question is "no", then ToDo for Yuri: when I add Observer
to NetworkPortalDetector it should be immediately called with current status.

[ygorshenin1, 2013-04-04 09:23:54]

On 2013/04/03 19:56:17, Denis Kuznetsov wrote:
> Fixed Nikita's nits, changed implementation to NetworkPortalDetector.
> 

Currently, you'll get notification, but not immediately. I'm currently working
on AddAndFireObserver() concept.

> Question for Yuri : If we are already behind captive portal and I call
> NetworkPortalDetector::ForcePortalDetection, will I get notification in
Observer
> (on the one hand, state have not changed, on the other, I forced
re-detection). 
> If answer to previous question is "no", then ToDo for Yuri: when I add
Observer
> to NetworkPortalDetector it should be immediately called with current status.

[ygorshenin1, 2013-04-04 09:24:00]

lgtm

[commit-bot: I haz the power, 2013-04-04 09:41:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/13553002/9001

[commit-bot: I haz the power, 2013-04-04 12:12:00]

Change committed as 192311