Disables HTML notifications when rich notifications are enabled.

Disables HTML notifications when rich notifications are enabled.

This works by adding a new flag to the content layer:
kDisableHTMLNotifications, which causes Chrome not to expose the
webkitNotifications.createHTMLNotification function to JS contexts.
Chrome appends this switch to new renderer processes when appropriate
in ChromeContentBrowserClient.

BUG=225918
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193005

[dewittj, 2013-04-05 20:31:17]

PTAL, this removes the webkitNotifications.createHTMLNotification function when
new "Rich" notifications are enabled.

[miket_OOO, 2013-04-08 21:48:54]

lgtm

https://codereview.chromium.org/13533019/diff/2003/chrome/browser/extensions/...
File chrome/browser/extensions/notifications_apitest.cc (right):

https://codereview.chromium.org/13533019/diff/2003/chrome/browser/extensions/...
chrome/browser/extensions/notifications_apitest.cc:22:
message_center::switches::kEnableRichNotifications);
I think this should be a 4-space indent. Same with below.

[dewittj1, 2013-04-08 22:29:03]

brettw, PTAL at:
chrome/renderer/chrome_render_view_observer.cc
content/public/common/content_switches.{h,cc}

or let me know if you'd prefer joi@ to look at content/public.

[brettw, 2013-04-08 23:03:24]

lgtm

[commit-bot: I haz the power, 2013-04-08 23:32:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dewittj@chromium.org/13533019/13002

[commit-bot: I haz the power, 2013-04-09 00:36:27]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-04-09 00:39:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dewittj@chromium.org/13533019/13002

[commit-bot: I haz the power, 2013-04-09 04:37:21]

Change committed as 193005

[PhistucK, 2013-04-09 09:44:39]

Please, make sure you inform all extension developers about not supporting HTML
notifications anymore, specifically extension authors that already use it within
the Chrome Web Store.

[dewittj, 2013-04-11 05:50:32]

On 2013/04/09 09:44:39, PhistucK wrote:
> Please, make sure you inform all extension developers about not supporting
HTML
> notifications anymore, specifically extension authors that already use it
within
> the Chrome Web Store.

We are readying communications to that effect.  Thanks for the reminder.